Handle too large PC/SC buffer values #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcsc-lite starting from 1.8.14 provides 65548 byte receive buffers to IFDHTransmitToICC(), which is a maximal extended APDU size. Unfortunately this is more than CT API can use (16 bits). If more than 65536 bytes are about to be sent, return IFD_PROTOCOL_NOT_SUPPORTED. Receive at most 65536 bytes. pcsc-lite will always specify 65548 buffer, even if the client application requests less; therefore we cannot return an error in this case. Discussion: https://lists.alioth.debian.org/pipermail/pcsclite-muscle/Week-of-Mon-20151109/000493.html
|
Any news on this? I've tested the patch and it works for me. |
|
OpenCT is not actively maintained any more (latest commit in 2013). Maybe @alonbl can review your patch. He is the latest active OpenCT maintainer. |
|
Any news on this? |
|
Hi @saper, I can release, no problem, I could no verify his one... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pcsc-lite starting from 1.8.14 provides 65548 byte
receive buffers to IFDHTransmitToICC(), which is
a maximal extended APDU size. Unfortunately this
is more than CT API can use (16 bits).
If more than 65536 bytes are about to be sent,
return IFD_PROTOCOL_NOT_SUPPORTED.
Receive at most 65536 bytes. pcsc-lite will always
specify 65548 buffer, even if the client application
requests less; therefore we cannot return an error
in this case.
Discussion:
https://lists.alioth.debian.org/pipermail/pcsclite-muscle/Week-of-Mon-20151109/000493.html