pass session->checklist_id to oscap_htable_get in get_html_guide #745
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In b8defed we moved to using s->checklist_id instead of hard coding xccdf.xml. However, this change was forgotten in ds_sds_session_get_html_guide which leads to the following error when trying to get the HTML guide: Internal error: Could not acquire handle to xccdf.xml source. This change migrates ds_sds_session_get_html_guide to also use s->checklist_id and thus fixes the issue. Fixes: #744
|
Can one of the admins verify this patch? |
Member
|
@openscap-jenkins add to whitelist |
Member
|
Awesome! Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In b8defed we moved to using
s->checklist_idinstead of hard codingxccdf.xml. However, this change was forgotten inds_sds_session_get_html_guidewhich leads to the following error when trying to get the HTML guide:This change migrates
ds_sds_session_get_html_guideto also uses->checklist_idand thus fixes the issue.Tests missing and are left to the more knowledgeable maintainer ;)
Fixes: #744