Improve the OAA UX. #112
Improve the OAA UX. #112
Conversation
|
Hello @matejak! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2020-05-26 15:35:43 UTC |
matejak
force-pushed
the
ux_fixes
branch
2 times, most recently
from
31f11f8
to
5bbea95
Compare
|
The inspection completed: 2 updated code elements |
There was a problem hiding this comment.
Much needed improvement, the list of changes is now scrollable, see screenshots:
But I don't like much the changes to the Profile description.
Just like the profile changes, it can be equally frustrating to not be able to read the whole descriptions.
A feature that could be interesting is to just show the titles, and make them expandable to see the description, but this is probably for another PR.
- Set minimal height to profile view and to the changes view. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1781790
I realized it was scrollable before, and now it shows a higher amount of lines. |
The PR OpenSCAP#112 marked this string as translatable, and changed it in the process. However, the string is already present elsewhere in the source code, so this move messed things up for translators. This change reverts the URL->URI change, and leaves the GUI string "translatable", as there is no way how to record the reason for this decision, so the situation doesn't repeat again. As a result, it is now the job of the translation framework to deal with the duplication gracefully.
Abbreviate profile descriptions to 4-9 lines based on total profile count.- see Abbreviate profile descriptions based on total profile count #113Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1781790
Remarks: This PR can't be tested on Fedora, as liboscap depends on gconf2 that is not part of the installed system. Putting gconf2 into the Fedora update image breaks the system completely, likely because it needs post-install scriplets to perform important tasks. The only way to test is to use a RHEL8 installation s.a.
boot.imgin a subdirectory of http://10.43.136.2/trees/rhel-8-scratch-temp/You may not be able to get content to the addon if #111 is not merged - content is not part of that boot image, and the installer update image of 19MB seems to be too big to get through.