Add support for the firstboot remediation - RHEL8 #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matejak
force-pushed
the
firstboot-rhel8
branch
2 times, most recently
from
0199014
to
930427b
Compare
|
The inspection completed: 1 new issues, 4 updated code elements |
OpenSCAP can support a new remediation type - a classical scan + remediate that is executed during the first boot. This PR adds support for this functionality, and allows to control it via a remediate kickstart property.
|
I have tested with the latest update and it works fine with the latest RHEL 8.6. |
jan-cerny
approved these changes
Mar 7, 2022
matejak
commented
Mar 8, 2022
| OSCAP_REMEDIATE_HTML_REPORT='{report_path}' | ||
| """) | ||
| if ds_id: | ||
| config += "OSCAP_REMEDIATE_DATASTREAM_ID='{ds_id}'\n" |
There was a problem hiding this comment.
ouch, we miss the tiny, but important letter f here and on lines below. The ds_id doesn't get substituted.
There was a problem hiding this comment.
Then how its possible that it worked? What did I test?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of #189 to RHEL8