New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ubah aikon menu Sekretariat supaya berbeda dengan Cetak Surat #906

Closed
eddieridwan opened this Issue Apr 3, 2018 · 10 comments

Comments

2 participants
@eddieridwan
Collaborator

eddieridwan commented Apr 3, 2018

Saat ini aikon menu Sekretariat sama dengan menu Cetak Surat. Sebaiknya dibedakan.

icon-sekretariat

@eddieridwan

This comment has been minimized.

Collaborator

eddieridwan commented Apr 3, 2018

Perubahan dilakukan di tabel setting_modul.
Cara melakukan perubahan adalah melalui migrasi di models/database_model.php.
Tambahkan database commandnya di method migrasi_211_ke_212().
Lihat contoh perubahan setting_modul lainnya di file itu.

@eddieridwan

This comment has been minimized.

Collaborator

eddieridwan commented Apr 3, 2018

Kolom icon_kecil untuk Sekretariat juga perlu diubah (cari yang sesuai dengan aikon besar yang dipilih). Aikon kecil ini ditampilkan di menu drop-down di avatar user (sebelah kanan atas) pada waktu menampilkan menu Peta).

icon-kecil

@kodingku

This comment has been minimized.

kodingku commented Apr 3, 2018

icon sekretariat dan small icon di plan sudah saya rubah,itu dari database pak,dan untuk membuat pull request nya??
apakah yg saya kirim dbnya atau gmna?? karna tidak ada file yg diedit,kalaupun di database_model command yg dimaksud?? query atau hanya comand tanda // slash

@eddieridwan

This comment has been minimized.

Collaborator

eddieridwan commented Apr 3, 2018

Cukup di database_model.php. Method migrasi_211_ke_212() nanti dieksekusi pada waktu menjalankan Database > Migrasi DB. Jadi jangan ubah database secara manual. Tes dulu menggunakan Database > Migrasi DB. Itu fungsinya database_model.php: untuk mengubah database melalui Migrasi DB.

@eddieridwan

This comment has been minimized.

Collaborator

eddieridwan commented Apr 3, 2018

Pull request tidak pernah ada databasenya. Perubahan database selalu melalui database_model.php yang dijalankan pada waktu Database > Migrasi DB.

@kodingku

This comment has been minimized.

kodingku commented Apr 3, 2018

Ok sdh d migrasi db dan sdh berhasil ko pak,selanjutnya??

@kodingku

This comment has been minimized.

kodingku commented Apr 3, 2018

@eddieridwan

This comment has been minimized.

Collaborator

eddieridwan commented Apr 3, 2018

Kalau sudah ok, ya silakan kirim pull requestnya. PR-nya seharusnya hanya berisi satu file, yaitu perubahan di database_model.php.

@eddieridwan

This comment has been minimized.

Collaborator

eddieridwan commented Apr 3, 2018

Di method migrasi_211_ke_212() di database_model.php tambahkan command semacam berikut:

    // Ubah ikon modul sekretariat
    $this->db->where('url','sekretariat')->update('setting_modul',array('ikon'=>'ikon_baru.png', 'ikon_kecil'=>'fa fa-ikon-baru fa-lg'));
@eddieridwan

This comment has been minimized.

Collaborator

eddieridwan commented May 3, 2018

Sudah dicommit ke master melalui PR #907

@eddieridwan eddieridwan closed this May 3, 2018

@eddieridwan eddieridwan moved this from SEDANG DIKERJAKAN to SUDAH DI MASTER in Rilis yang sedang dikerjakan May 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment