From 22fbc7271fb8a04c70081d80d4c365ec8f453780 Mon Sep 17 00:00:00 2001
From: Vlad Patrascu <vladp@opensips.org>
Date: Fri, 13 Nov 2020 18:47:26 +0200
Subject: [PATCH] pua_mi: fix parameter name in pua_subscribe MI command

Also improve the docs for pua_subscribe by adding an usage example
and proper indexing.

(cherry picked from commit 0d20cd55d1981b56795d44d02d46bd02329dad8e)
---
 modules/pua_mi/doc/pua_mi_admin.xml | 19 ++++++++++++++-----
 modules/pua_mi/mi_func.c            |  2 +-
 2 files changed, 15 insertions(+), 6 deletions(-)

diff --git a/modules/pua_mi/doc/pua_mi_admin.xml b/modules/pua_mi/doc/pua_mi_admin.xml
index c718d7b94cf..61b16ae5510 100644
--- a/modules/pua_mi/doc/pua_mi_admin.xml
+++ b/modules/pua_mi/doc/pua_mi_admin.xml
@@ -79,9 +79,9 @@ modparam("pua_mi", "presence_server", "sip:pa@opensips.org:5075")
 		<para>The module does not export functions to be used
 		in configuration script.</para>
 	</section>	
-	<section>
+	<section id="exported_mi_functions" xreflabel="Exported MI Functions">
 		<title>Exported MI functions</title>
-		<section>
+		<section id="mi_pua_publish" xreflabel="pua_publish">
 				<title>
 				<function moreinfo="none">pua_publish</function>
 				</title>
@@ -153,8 +153,7 @@ opensips-cli -x mi pua_publish sip:system@opensips.org 3600 presence application
 		</example>
 		</section>
 
-	</section>		
-	<section>
+	<section id="mi_pua_subscribe" xreflabel="pua_subscribe">
 		<title>
 			<function moreinfo="none">pua_subscribe</function>
 		</title>
@@ -177,7 +176,7 @@ opensips-cli -x mi pua_publish sip:system@opensips.org 3600 presence application
 
 			<listitem>
 				<para>
-					<emphasis>event package</emphasis>
+					<emphasis>event_package</emphasis>
 				</para>	
 			</listitem>
 			<listitem>
@@ -187,6 +186,16 @@ opensips-cli -x mi pua_publish sip:system@opensips.org 3600 presence application
 				    </para> 
 			</listitem>	
 			</itemizedlist>
+		<example>
+		<title><function>pua_subscribe</function> FIFO example</title>
+	<programlisting format="linespecific">
+...
+<![CDATA[
+opensips-cli -x mi pua_subscribe sip:system@opensips.org sip:400@opensips.org presence 3600
+]]>
+</programlisting>
+		</example>
 	</section>
+</section>
 </chapter>
 
diff --git a/modules/pua_mi/mi_func.c b/modules/pua_mi/mi_func.c
index 8a8b2495be9..a5821a60b09 100644
--- a/modules/pua_mi/mi_func.c
+++ b/modules/pua_mi/mi_func.c
@@ -434,7 +434,7 @@ mi_response_t *mi_pua_subscribe(const mi_params_t *params,
 		return init_mi_error(400, MI_SSTR("Bad uri"));
 	}
 
-	if (get_mi_string_param(params, "event",
+	if (get_mi_string_param(params, "event_package",
 		&event.s, &event.len) < 0)
 		return init_mi_param_error();