From f8e0cbbecf9d6156bb3f9b4b9509bcf80f0a3ec1 Mon Sep 17 00:00:00 2001 From: Bogdan-Andrei Iancu Date: Wed, 29 May 2019 16:43:31 +0300 Subject: [PATCH] [utils] Fixed compiler warning Even if harmless, make the code consistent and avoid warnings - if using null-termiated functions, be sure you have the space for the the ending NULL. Reported by Dan Pascu ( @danpascu ) (cherry picked from commit decbd1bddee7a77194fcc989f12b587e1b7ee548) --- utils/db_berkeley/bdb_recover.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/utils/db_berkeley/bdb_recover.c b/utils/db_berkeley/bdb_recover.c index e53f07e6769..e9ddc8fe55d 100644 --- a/utils/db_berkeley/bdb_recover.c +++ b/utils/db_berkeley/bdb_recover.c @@ -483,9 +483,7 @@ int extract_key(table_p tp, char* k, char* d) p = k; /*copy data so we can tokenize w.o trampling */ - len = strlen(d); - strncpy(buf, d, len); - buf[len] = 0; + strcpy(buf, d); s = strtok(buf, "|"); while(s!=NULL && ncolp[n]->kflag ) { - strncpy(p, s, len); + memcpy(p, s, len); p+=len; *p = '|';