From f9b259311e8b8c66d3fb19e3b0ff3171c1a0f996 Mon Sep 17 00:00:00 2001 From: Razvan Crainea Date: Wed, 9 Feb 2022 12:07:35 +0200 Subject: [PATCH] proto_tls: disable async by default According to ticket #2724, async tls might lead to unexpected behavior. We are disabling it by default until we figure out what is going on and fix the core problem. --- modules/proto_tls/doc/proto_tls_admin.xml | 2 +- modules/proto_tls/proto_tls.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/modules/proto_tls/doc/proto_tls_admin.xml b/modules/proto_tls/doc/proto_tls_admin.xml index b1f57af3a06..78751826d93 100644 --- a/modules/proto_tls/doc/proto_tls_admin.xml +++ b/modules/proto_tls/doc/proto_tls_admin.xml @@ -509,7 +509,7 @@ param("proto_tls", "tls_send_timeout", 200) # number of milliseconds operations like connect and write. - Default value is 1 (enabled). + Default value is 0 (disabled). Set <varname>tls_async</varname> variable diff --git a/modules/proto_tls/proto_tls.c b/modules/proto_tls/proto_tls.c index ecba0059b0f..7fc656e01f0 100644 --- a/modules/proto_tls/proto_tls.c +++ b/modules/proto_tls/proto_tls.c @@ -89,7 +89,7 @@ struct tls_mgm_binds tls_mgm_api; static int tls_port_no = SIPS_PORT; /* 1 if tls connect & write should be async */ -static int tls_async = 1; +static int tls_async = 0; /* Number of milliseconds that a worker will block waiting for a local * connect - if connect op exceeds this, it will get passed to tls main*/