Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup python 2 leftovers #29

Open
tritemio opened this issue Jun 11, 2019 · 0 comments
Open

Cleanup python 2 leftovers #29

tritemio opened this issue Jun 11, 2019 · 0 comments
Labels
enhancement good first issue help wanted

Comments

@tritemio
Copy link

tritemio commented Jun 11, 2019 •
edited
Loading

Overview

FRETBursts 0.7+ drops support for python 2.7. It is time to remove some old cruft!

This is an easy issue that can help first-time contributors to get the hands dirty with FRETBursts codebase.

Technical description

FRETBursts uses the future package to assure python 2 compatibility:

https://python-future.org/compatible_idioms.html

Imports "from future" can be removed now. In particular, these lines be safely removed

  • from __future__ import ...
  • from builtins import ...
  • check other imports of past, future and builtins.

Also the future package should be removed from the dependencies (see setup.py).

If you use FRETBursts this is a good issue to start contributing!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tritemio