Skip to content

/ OpenSMTPD-extras

Permalink
Browse files

remove all experimental filters from -extras

  • Loading branch information
@poolpOrg
poolpOrg committed Jul 6, 2016
1 parent 87154eb commit da8bc3dc23bc6350ee05ef7744c4c42386aab836
Unified Split
Showing with 0 additions and 5,858 deletions.
  1. +0 −10 extras/filters/filter-clamav/Makefile.am
  2. +0 −95 extras/filters/filter-clamav/filter-clamav.8
  3. +0 −301 extras/filters/filter-clamav/filter_clamav.c
  4. +0 −9 extras/filters/filter-dkim-signer/Makefile.am
  5. +0 −108 extras/filters/filter-dkim-signer/filter-dkim-signer.8
  6. +0 −333 extras/filters/filter-dkim-signer/filter_dkim_signer.c
  7. +0 −14 extras/filters/filter-dnsbl/Makefile.am
  8. +0 −103 extras/filters/filter-dnsbl/filter-dnsbl.8
  9. +0 −187 extras/filters/filter-dnsbl/filter_dnsbl.c
  10. +0 −11 extras/filters/filter-lua/Makefile.am
  11. +0 −480 extras/filters/filter-lua/filter_lua.c
  12. +0 −10 extras/filters/filter-pause/Makefile.am
  13. +0 −90 extras/filters/filter-pause/filter-pause.8
  14. +0 −89 extras/filters/filter-pause/filter_pause.c
  15. +0 −11 extras/filters/filter-perl/Makefile.am
  16. +0 −305 extras/filters/filter-perl/filter_perl.c
  17. +0 −11 extras/filters/filter-python/Makefile.am
  18. +0 −539 extras/filters/filter-python/filter_python.c
  19. +0 −18 extras/filters/filter-regex/Makefile.am
  20. +0 −90 extras/filters/filter-regex/filter-regex.8.in
  21. +0 −26 extras/filters/filter-regex/filter-regex.conf
  22. +0 −126 extras/filters/filter-regex/filter-regex.conf.5.in
  23. +0 −302 extras/filters/filter-regex/filter_regex.c
  24. +0 −13 extras/filters/filter-rspamd/Makefile.am
  25. +0 −213 extras/filters/filter-rspamd/filter_rspamd.c
  26. +0 −68 extras/filters/filter-rspamd/fixme.c
  27. +0 −1,011 extras/filters/filter-rspamd/json.c
  28. +0 −283 extras/filters/filter-rspamd/json.h
  29. +0 −409 extras/filters/filter-rspamd/rspamd.c
  30. +0 −85 extras/filters/filter-rspamd/rspamd.h
  31. +0 −10 extras/filters/filter-spamassassin/Makefile.am
  32. +0 −130 extras/filters/filter-spamassassin/filter-spamassassin.8
  33. +0 −368 extras/filters/filter-spamassassin/filter_spamassassin.c
10 extras/filters/filter-clamav/Makefile.am
View file

This file was deleted.

95 extras/filters/filter-clamav/filter-clamav.8
View file

This file was deleted.

11 comments on commit da8bc3d

@assistcontrol

This comment has been minimized.

Sign in to view
Copy link

@assistcontrol assistcontrol replied Jul 24, 2016

Oh no! Why? I absolutely rely upon filter-dnsbl. Having to install spamassassin just for a single lookup that the filter-dnsbl did perfectly is really unfortunate.

What would it take for filter-dnsbl to come back? I never encountered a single problem using it in production...
@poolpOrg

This comment has been minimized.

Sign in to view
Copy link
Member Author

@poolpOrg poolpOrg replied Jul 25, 2016

Oh no! Why?

Stay on...

I absolutely rely upon filter-dnsbl.

There you go, the filters were enabled for developers, not users, and people have disregarded this point to start relying on them while we're not done working on them.

Filters are broken, the API they rely upon is still moving and we need to be able to work on it without users complaining that they rely on them, so I fixed the problem by disabling all filters and making them available as separate branches for developers.

You can still work your way around and run with them, but you'll need to figure it out by yourself and deal with breakage.
@assistcontrol

This comment has been minimized.

Sign in to view
Copy link

@assistcontrol assistcontrol replied Jul 25, 2016

That is a fair response. Reading back over it, my original message just comes across as whiny and entitled. What I should have said was: "I absolutely love the dnsbl filter, and I hope that it makes its way out of experimental."

I hadn't noticed that it got moved into its own branch. Without that info, I assumed those filters were being dropped entirely. Now I see that they are closed for renovations.

Sorry for the noise, and thanks for clarifying the status for me.
@poolpOrg

This comment has been minimized.

Sign in to view
Copy link
Member Author

@poolpOrg poolpOrg replied Jul 26, 2016

Nope nope, don't worry, I didn't read it that way ;-)

I'm just clarifying that the reason we removed it is precisely because people started relying on it which makes it hard for us to do any change.

We enabled for developers and somehow filters were written for users when they should have been written to stress particular bits of the API.

If we disable them and work on the API, they can be fixed and re-enabled way sooner than if we have to deal with plenty of users running with them, which is why I did that commit.
@zeroflags

This comment has been minimized.

Sign in to view
Copy link

@zeroflags zeroflags replied Jul 15, 2017

Hi Gilles, hope you're doing well. This thread is over a year old and I wonder whether there has been any progress in this regard. Have your team been able to fine tune the API since? I mean I really like the OpenSMTPD philosophy and I would really love to use it with Rspamd (and I bet I am not the only one, LOL).

Since SpamPD is broken (does not automatically start properly on different listening ports) and SpamAssassin is obsolete (I know it works somehow, but it's a clumsy system), and not having any sort of milter/filter way to deliver messages to Rspamd (or any other spam/virus filtering system) other than writing my own SMTP proxy (which I did, but obviously not a production-ready product); makes this whole project useless (no offence intended) even for private use (having SPF, DKIM, ARC and DMARC options to deal with spam and trust). DKIMproxy does not (and cannot) handle everything.

Keeping fingers crossed that you are going to have some good news for the OpenSMTPD tribe soon! :-) Cheers and thanks!
@zeroflags

This comment has been minimized.

Sign in to view
Copy link

@zeroflags zeroflags replied Jul 19, 2017

No need to worry Gilles, I got the point! ;-)

A reply to myself, stick to Postfix, mate! ;-)
@poolpOrg

This comment has been minimized.

Sign in to view
Copy link
Member Author

@poolpOrg poolpOrg replied Jul 19, 2017

If you expect answers < week these days, you're out of luck.

There's ongoing work in that area, I hope we have a prototype working for testing by this winter, if you rely on filters and can't work with spampd, then you're petter of sticking to Postfix indeed.
@assistcontrol

This comment has been minimized.

Sign in to view
Copy link

@assistcontrol assistcontrol replied Jul 19, 2017

@zeroflags doesn't speak for the rest of us, who are in support of filters returning when they're ready to return.

Gilles, is the dnsbl filter part of the prototype you're working on, or is the focus on the SA/rspamd integration?
@poolpOrg

This comment has been minimized.

Sign in to view
Copy link
Member Author

@poolpOrg poolpOrg replied Jul 20, 2017

The focus is not on a particular filter, the focus is on removing the entire filter code from smtpd and moving it to a new daemon, smtpfd, which smtpd communicates with.

I've already removed the filter code from smtpd, @ericfaurot is currently working on the smtpfd code and I'm about to start working on the protocol code between smtpd and smtpfd.

When this is done, we'll adapt some of the existing filters including dnsbl / SA/rspamd in no particular order :-)
@assistcontrol

This comment has been minimized.

Sign in to view
Copy link

@assistcontrol assistcontrol replied Jul 20, 2017

Ah got it. Thanks, Gilles!
@zeroflags

This comment has been minimized.

Sign in to view
Copy link

@zeroflags zeroflags replied Aug 21, 2017

@assistcontrol ...wasn't talking on your behalf at all, was talking on behalf of the OpenSMTPD tribe.

@poolpOrg Thanks for your reply. Take your time, you obviously do, LOL. I've found my way anyway. Thanks and cheers!
Please sign in to comment.