Add tests for SettingsSyncIntentService #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekigamba
requested review from
bennsimon
and removed request for
dubdabasoduba
- Add test for onCreate - Add test for onHandleIntent
ekigamba
force-pushed
the
kigamba-tt-8-9-2020
branch
from
ef98dff
to
f8ed7e6
Compare
bennsimon
requested changes
Sep 14, 2020
Comment on lines
-225
to
-236
|
|
||
| public void setHttpAgent(HTTPAgent httpAgent) { | ||
| this.httpAgent = httpAgent; | ||
| } | ||
|
|
||
| public void setBaseUrl(String baseUrl) { | ||
| this.baseUrl = baseUrl; | ||
| } | ||
|
|
||
| public void setSharedPreferences(AllSharedPreferences sharedPreferences) { | ||
| this.sharedPreferences = sharedPreferences; | ||
| } |
There was a problem hiding this comment.
I had added the setters on another testing PR. Their role was to enable setting the values instead of using the constructor. I no longer need them
| public void tearDown() throws Exception { | ||
| ReflectionHelpers.setStaticField(Context.class, "context", null); | ||
| } | ||
|
|
||
| @Test | ||
| public void onHandleIntent() { |
There was a problem hiding this comment.
Could you update the test name to match the convention.
bennsimon
approved these changes
Sep 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #633