New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve map ui #70
Merged
Merged
improve map ui #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lines throw an error in openlayers if the text is empty. It results in the rest of the init functions not running and the map not working correcly. The patch only catches the error but does not resolve the real problem.
- add current view position of the map (lat, lon) - always generate a permalink ... no marker is necessary - update link on layer change, view change, marker change and textinput change (all variables that go into the link) - remove active layer list ... all current layers are included in the link. The list was redundant to the view menu and can not translated.
This was referenced Oct 17, 2015
Closed
- remove "marker" checkbox in wikipedia submenue because it is redundant to the wikipedia main checkbox - refactor code to separate set layer options and change ui state - improve cookie loading for wikipedia layer to restore old state on load - issue still open: OpenSeaMap#24 - thumbnail option is not an extra layer - only "real" layers are stored in the layer-string
… them in a map marker Uses the he library (https://github.com/mathiasbynens/he) for encoding the string. No markup is now possible in the mtext URL parameter. Linebreaks (\n) are converted to <br/> after encoding.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
You can see the site with my changes here: http://dev-map.brasshack.de/