Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve map ui #70

Merged
merged 11 commits into from Dec 28, 2015
Merged

improve map ui #70

merged 11 commits into from Dec 28, 2015

Conversation

aAXEe
Copy link
Contributor

@aAXEe aAXEe commented Oct 17, 2015

You can see the site with my changes here: http://dev-map.brasshack.de/

This lines throw an error in openlayers if the text is empty.
It results in the rest of the init functions not running and the map not working correcly.

The patch only catches the error but does not resolve the real problem.
- add current view position of the map (lat, lon)
- always generate a permalink ... no marker is necessary
- update link on layer change, view change, marker change and textinput change (all variables that go into the link)
- remove active layer list ... all current layers are included in the link. The list was redundant to the view menu and can not translated.
- remove "marker" checkbox in wikipedia submenue because it is redundant to the wikipedia main checkbox
- refactor code to separate set layer options and change ui state
- improve cookie loading for wikipedia layer to restore old state on load
- issue still open: OpenSeaMap#24
  - thumbnail option is not an extra layer
  - only "real" layers are stored in the layer-string
… them in a map marker

Uses the he library (https://github.com/mathiasbynens/he) for encoding the string.
No markup is now possible in the mtext URL parameter. Linebreaks (\n) are converted to <br/> after encoding.
@ehrenfeu ehrenfeu mentioned this pull request Oct 21, 2015
@aAXEe aAXEe merged commit 8649157 into OpenSeaMap:master Dec 28, 2015
@aAXEe aAXEe deleted the dev-improveMapUI branch December 28, 2015 22:14
aAXEe added a commit that referenced this pull request Dec 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant