From e8b4dde32ec693fe3a6d4e60287dc2532684d575 Mon Sep 17 00:00:00 2001 From: Frank Dana Date: Fri, 4 Dec 2020 09:25:30 -0500 Subject: [PATCH] Timeline::GetClip: Add anti-slicing unit tests (#596) --- tests/Timeline_Tests.cpp | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/tests/Timeline_Tests.cpp b/tests/Timeline_Tests.cpp index 536b21334..0956366f3 100644 --- a/tests/Timeline_Tests.cpp +++ b/tests/Timeline_Tests.cpp @@ -437,20 +437,26 @@ TEST(GetClip_by_id) std::string clip2_id("CLIP00002"); clip2.Id(clip2_id); clip2.Layer(2); + clip2.Waveform(true); t.AddClip(&clip1); t.AddClip(&clip2); - auto matched = t.GetClip(clip1_id); + // We explicitly want to get returned a Clip*, here + Clip* matched = t.GetClip(clip1_id); CHECK_EQUAL(clip1_id, matched->Id()); CHECK_EQUAL(1, matched->Layer()); - auto matched2 = t.GetClip(clip2_id); + Clip* matched2 = t.GetClip(clip2_id); CHECK_EQUAL(clip2_id, matched2->Id()); CHECK_EQUAL(false, matched2->Layer() < 2); - auto matched3 = t.GetClip("BAD_ID"); + Clip* matched3 = t.GetClip("BAD_ID"); CHECK_EQUAL(true, matched3 == nullptr); + + // Ensure we can access the Clip API interfaces after lookup + CHECK_EQUAL(false, matched->Waveform()); + CHECK_EQUAL(true, matched2->Waveform()); } TEST(GetClipEffect_by_id)