New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build fails with imagemagick-7 due to API changes #60
Comments
|
I am also having this very same issue after upgrading to ImageMagick 7.0.7.19 on a Gentoo distro (4.9.72). |
|
Same build issue here on a Mageia Cauldron distro with ImageMagick 7.0.7.21. |
|
With this ROSA patch libopenshot build against ImageMagick >= 7.0 |
|
How do I get CMake to use version 6? It is using 7. I tried to set the version used in |
|
@steinybot - There was a patch by @gary9872 over at: #85 and in the comments, there's also a patch attached by another dev that adds backwards compatibility with older versions of ImageMagick. So, perhaps that is what you're looking for? |
|
@peanutbutterandcrackers yeah I saw those but what I'm trying to find is a way to get cmake to stop using ImageMagick 7 and use version 6 instead. I guess I could apply the patch and just use 7 although that potentially brings other problems. |
|
@steinybot - Hmm... I haven't yet compiled the code with the patch integrated, myself. But I am certain that it works well. The patch-creator (in the comments) is a known contributor. Sorry for the late reply, BTW. Also OpenShot version 2.4.2 is out. It was released just this morning! |
|
I finally figured out how to get cmake to do what I wanted. Here is what works for me on MacOS: Key things to note here is to set both the |
|
@steinybot - Yay! awesome! [I'm really looking forward to seeing your PRs soon, good sir! |
|
@peanutbutterandcrackers Sadly it doesn't really work. It fails to link. I've been bashing at it for 2 days and I can't for the life of me figure out why it doesn't work. For reference here is a stackoverflow question and a imagemagic forum post, neither of which have any solutions. I'll see if I have more luck with 7. |
|
Nope. Exactly the same linker errors with version 7 after applying the patches for 85. |
|
I'm sorry I don't really know how to resolve the issue... |
|
Yeah, sorry, I've got nothing. Fedora 28 is still on ImageMagick 6.9.9.38. This may very well be why. (Not libopenshot specifically, but if there were significant breaking API changes with 7.0 then It's possible it's being held back because apps that build with IM6 haven't caught up yet.) As for why your build attempts with ImageMagick 6 are failing, no idea. I think we'd have to see the entirety of CMake and Make's output, at the very least. Building under MacOS is very different from building under Linux, and there can be a world of detail in those "..." yadda-yaddas. Just the error messages doesn't really provide enough context. The $ grep -i magick CMakeCache.txt
//Path to the ImageMagick binary directory.
IMAGEMAGICK_BINARY_PATH:PATH=/usr/bin
//Path to ImageMagick's composite executable.
IMAGEMAGICK_COMPOSITE_EXECUTABLE:FILEPATH=/usr/bin/composite
//Path to ImageMagick's convert executable.
IMAGEMAGICK_CONVERT_EXECUTABLE:FILEPATH=/usr/bin/convert
//Path to ImageMagick's import executable.
IMAGEMAGICK_IMPORT_EXECUTABLE:FILEPATH=/usr/bin/import
//Path to ImageMagick's mogrify executable.
IMAGEMAGICK_MOGRIFY_EXECUTABLE:FILEPATH=/usr/bin/mogrify
//Path to ImageMagick's montage executable.
IMAGEMAGICK_MONTAGE_EXECUTABLE:FILEPATH=/usr/bin/montage
//Path to the ImageMagick binary directory.
ImageMagick_EXECUTABLE_DIR:PATH=/usr/bin
//Path to the ImageMagick arch-specific include dir.
ImageMagick_Magick++_ARCH_INCLUDE_DIR:PATH=/usr/include/ImageMagick-6
//Path to the ImageMagick arch-independent include dir.
ImageMagick_Magick++_INCLUDE_DIR:PATH=/usr/include/ImageMagick-6
//Path to the ImageMagick Magick++ library.
ImageMagick_Magick++_LIBRARY:FILEPATH=/usr/lib64/libMagick++-6.Q16.so
//Path to the ImageMagick arch-specific include dir.
ImageMagick_MagickCore_ARCH_INCLUDE_DIR:PATH=/usr/include/ImageMagick-6
//Path to the ImageMagick arch-independent include dir.
ImageMagick_MagickCore_INCLUDE_DIR:PATH=/usr/include/ImageMagick-6
//Path to the ImageMagick Magick++ library.
ImageMagick_MagickCore_LIBRARY:FILEPATH=/usr/lib64/libMagickCore-6.Q16.so
//Path to the ImageMagick arch-specific include dir.
ImageMagick_MagickWand_ARCH_INCLUDE_DIR:PATH=/usr/include/ImageMagick-6
//Path to the ImageMagick arch-independent include dir.
ImageMagick_MagickWand_INCLUDE_DIR:PATH=/usr/include/ImageMagick-6
//Path to the ImageMagick Magick++ library.
ImageMagick_MagickWand_LIBRARY:FILEPATH=/usr/lib64/libMagickWand-6.Q16.so
openshot_LIB_DEPENDS:STATIC=general;/usr/lib64/libavformat.so;general;/usr/lib64/libavcodec.so;general;/usr/lib64/libavutil.so;general;/usr/lib64/libavdevice.so;general;/usr/lib64/libswscale.so;general;/usr/lib64/libavresample.so;general;/lib64/libopenshot-audio.so;general;Qt5::Widgets;general;Qt5::Core;general;Qt5::Gui;general;Qt5::Multimedia;general;Qt5::MultimediaWidgets;general;/usr/lib64/libzmq.so;general;-fopenmp;general;/usr/lib64/libMagick++-6.Q16.so;general;/usr/lib64/libMagickWand-6.Q16.so;general;/usr/lib64/libMagickCore-6.Q16.so;
//Details about finding ImageMagick
FIND_PACKAGE_MESSAGE_DETAILS_ImageMagick:INTERNAL=[/usr/lib64/libMagick++-6.Q16.so][/usr/lib64/libMagickWand-6.Q16.so][/usr/lib64/libMagickCore-6.Q16.so][v6.9.9-38()]
//ADVANCED property for variable: IMAGEMAGICK_BINARY_PATH
IMAGEMAGICK_BINARY_PATH-ADVANCED:INTERNAL=1
//ADVANCED property for variable: IMAGEMAGICK_COMPOSITE_EXECUTABLE
IMAGEMAGICK_COMPOSITE_EXECUTABLE-ADVANCED:INTERNAL=1
//ADVANCED property for variable: IMAGEMAGICK_CONVERT_EXECUTABLE
IMAGEMAGICK_CONVERT_EXECUTABLE-ADVANCED:INTERNAL=1
//ADVANCED property for variable: IMAGEMAGICK_IMPORT_EXECUTABLE
IMAGEMAGICK_IMPORT_EXECUTABLE-ADVANCED:INTERNAL=1
//ADVANCED property for variable: IMAGEMAGICK_MOGRIFY_EXECUTABLE
IMAGEMAGICK_MOGRIFY_EXECUTABLE-ADVANCED:INTERNAL=1
//ADVANCED property for variable: IMAGEMAGICK_MONTAGE_EXECUTABLE
IMAGEMAGICK_MONTAGE_EXECUTABLE-ADVANCED:INTERNAL=1
PC_Magick++_CFLAGS:INTERNAL=-I/usr/include/ImageMagick-6;-fopenmp;-DMAGICKCORE_HDRI_ENABLE=0;-DMAGICKCORE_QUANTUM_DEPTH=16
PC_Magick++_CFLAGS_I:INTERNAL=
PC_Magick++_CFLAGS_OTHER:INTERNAL=-fopenmp;-DMAGICKCORE_HDRI_ENABLE=0;-DMAGICKCORE_QUANTUM_DEPTH=16
PC_Magick++_FOUND:INTERNAL=1
PC_Magick++_INCLUDEDIR:INTERNAL=/usr/include/ImageMagick-6
PC_Magick++_INCLUDE_DIRS:INTERNAL=/usr/include/ImageMagick-6
PC_Magick++_LDFLAGS:INTERNAL=-lMagick++-6.Q16;-lMagickWand-6.Q16;-lMagickCore-6.Q16
PC_Magick++_LDFLAGS_OTHER:INTERNAL=
PC_Magick++_LIBDIR:INTERNAL=/usr/lib64
PC_Magick++_LIBRARIES:INTERNAL=Magick++-6.Q16;MagickWand-6.Q16;MagickCore-6.Q16
PC_Magick++_LIBRARY_DIRS:INTERNAL=
PC_Magick++_LIBS:INTERNAL=
PC_Magick++_LIBS_L:INTERNAL=
PC_Magick++_LIBS_OTHER:INTERNAL=
PC_Magick++_LIBS_PATHS:INTERNAL=
PC_Magick++_Magick++_INCLUDEDIR:INTERNAL=
PC_Magick++_Magick++_LIBDIR:INTERNAL=
PC_Magick++_Magick++_PREFIX:INTERNAL=
PC_Magick++_Magick++_VERSION:INTERNAL=
PC_Magick++_PREFIX:INTERNAL=/usr
PC_Magick++_STATIC_CFLAGS:INTERNAL=-I/usr/include/ImageMagick-6;-fopenmp;-DMAGICKCORE_HDRI_ENABLE=0;-DMAGICKCORE_QUANTUM_DEPTH=16
PC_Magick++_STATIC_CFLAGS_I:INTERNAL=
PC_Magick++_STATIC_CFLAGS_OTHER:INTERNAL=-fopenmp;-DMAGICKCORE_HDRI_ENABLE=0;-DMAGICKCORE_QUANTUM_DEPTH=16
PC_Magick++_STATIC_INCLUDE_DIRS:INTERNAL=/usr/include/ImageMagick-6
PC_Magick++_STATIC_LDFLAGS:INTERNAL=-lMagick++-6.Q16;-lMagick++-6.Q16;-llcms2;-lfreetype;-lfftw3;-lxml2;-lfontconfig;-lfreetype;-lXext;-lSM;-lICE;-lX11;-lXt;-llzma;-lbz2;-lz;-lltdl;-lm;-lgomp;-lm;-lMagickWand-6.Q16;-lMagickWand-6.Q16;-llcms2;-lfreetype;-lfftw3;-lxml2;-lfontconfig;-lfreetype;-lXext;-lSM;-lICE;-lX11;-lXt;-llzma;-lbz2;-lz;-lltdl;-lm;-lgomp;-lm;-lMagickCore-6.Q16;-lMagickCore-6.Q16;-llcms2;-lfreetype;-lfftw3;-lxml2;-lfontconfig;-lfreetype;-lXext;-lSM;-lICE;-lX11;-lXt;-llzma;-lbz2;-lz;-lltdl;-lm;-lgomp;-lm
PC_Magick++_STATIC_LDFLAGS_OTHER:INTERNAL=
PC_Magick++_STATIC_LIBDIR:INTERNAL=
PC_Magick++_STATIC_LIBRARIES:INTERNAL=Magick++-6.Q16;Magick++-6.Q16;lcms2;freetype;fftw3;xml2;fontconfig;freetype;Xext;SM;ICE;X11;Xt;lzma;bz2;z;ltdl;m;gomp;m;MagickWand-6.Q16;MagickWand-6.Q16;lcms2;freetype;fftw3;xml2;fontconfig;freetype;Xext;SM;ICE;X11;Xt;lzma;bz2;z;ltdl;m;gomp;m;MagickCore-6.Q16;MagickCore-6.Q16;lcms2;freetype;fftw3;xml2;fontconfig;freetype;Xext;SM;ICE;X11;Xt;lzma;bz2;z;ltdl;m;gomp;m
PC_Magick++_STATIC_LIBRARY_DIRS:INTERNAL=
PC_Magick++_STATIC_LIBS:INTERNAL=
PC_Magick++_STATIC_LIBS_L:INTERNAL=
PC_Magick++_STATIC_LIBS_OTHER:INTERNAL=
PC_Magick++_STATIC_LIBS_PATHS:INTERNAL=
PC_Magick++_VERSION:INTERNAL=6.9.9
PC_MagickCore_CFLAGS:INTERNAL=-I/usr/include/ImageMagick-6;-fopenmp;-DMAGICKCORE_HDRI_ENABLE=0;-DMAGICKCORE_QUANTUM_DEPTH=16
PC_MagickCore_CFLAGS_I:INTERNAL=
PC_MagickCore_CFLAGS_OTHER:INTERNAL=-fopenmp;-DMAGICKCORE_HDRI_ENABLE=0;-DMAGICKCORE_QUANTUM_DEPTH=16
PC_MagickCore_FOUND:INTERNAL=1
PC_MagickCore_INCLUDEDIR:INTERNAL=/usr/include/ImageMagick-6
PC_MagickCore_INCLUDE_DIRS:INTERNAL=/usr/include/ImageMagick-6
PC_MagickCore_LDFLAGS:INTERNAL=-lMagickCore-6.Q16
PC_MagickCore_LDFLAGS_OTHER:INTERNAL=
PC_MagickCore_LIBDIR:INTERNAL=/usr/lib64
PC_MagickCore_LIBRARIES:INTERNAL=MagickCore-6.Q16
PC_MagickCore_LIBRARY_DIRS:INTERNAL=
PC_MagickCore_LIBS:INTERNAL=
PC_MagickCore_LIBS_L:INTERNAL=
PC_MagickCore_LIBS_OTHER:INTERNAL=
PC_MagickCore_LIBS_PATHS:INTERNAL=
PC_MagickCore_MagickCore_INCLUDEDIR:INTERNAL=
PC_MagickCore_MagickCore_LIBDIR:INTERNAL=
PC_MagickCore_MagickCore_PREFIX:INTERNAL=
PC_MagickCore_MagickCore_VERSION:INTERNAL=
PC_MagickCore_PREFIX:INTERNAL=/usr
PC_MagickCore_STATIC_CFLAGS:INTERNAL=-I/usr/include/ImageMagick-6;-fopenmp;-DMAGICKCORE_HDRI_ENABLE=0;-DMAGICKCORE_QUANTUM_DEPTH=16
PC_MagickCore_STATIC_CFLAGS_I:INTERNAL=
PC_MagickCore_STATIC_CFLAGS_OTHER:INTERNAL=-fopenmp;-DMAGICKCORE_HDRI_ENABLE=0;-DMAGICKCORE_QUANTUM_DEPTH=16
PC_MagickCore_STATIC_INCLUDE_DIRS:INTERNAL=/usr/include/ImageMagick-6
PC_MagickCore_STATIC_LDFLAGS:INTERNAL=-lMagickCore-6.Q16;-lMagickCore-6.Q16;-llcms2;-lfreetype;-lfftw3;-lxml2;-lfontconfig;-lfreetype;-lXext;-lSM;-lICE;-lX11;-lXt;-llzma;-lbz2;-lz;-lltdl;-lm;-lgomp;-lm
PC_MagickCore_STATIC_LDFLAGS_OTHER:INTERNAL=
PC_MagickCore_STATIC_LIBDIR:INTERNAL=
PC_MagickCore_STATIC_LIBRARIES:INTERNAL=MagickCore-6.Q16;MagickCore-6.Q16;lcms2;freetype;fftw3;xml2;fontconfig;freetype;Xext;SM;ICE;X11;Xt;lzma;bz2;z;ltdl;m;gomp;m
PC_MagickCore_STATIC_LIBRARY_DIRS:INTERNAL=
PC_MagickCore_STATIC_LIBS:INTERNAL=
PC_MagickCore_STATIC_LIBS_L:INTERNAL=
PC_MagickCore_STATIC_LIBS_OTHER:INTERNAL=
PC_MagickCore_STATIC_LIBS_PATHS:INTERNAL=
PC_MagickCore_VERSION:INTERNAL=6.9.9
PC_MagickWand_CFLAGS:INTERNAL=-I/usr/include/ImageMagick-6;-fopenmp;-DMAGICKCORE_HDRI_ENABLE=0;-DMAGICKCORE_QUANTUM_DEPTH=16
PC_MagickWand_CFLAGS_I:INTERNAL=
PC_MagickWand_CFLAGS_OTHER:INTERNAL=-fopenmp;-DMAGICKCORE_HDRI_ENABLE=0;-DMAGICKCORE_QUANTUM_DEPTH=16
PC_MagickWand_FOUND:INTERNAL=1
PC_MagickWand_INCLUDEDIR:INTERNAL=/usr/include/ImageMagick-6
PC_MagickWand_INCLUDE_DIRS:INTERNAL=/usr/include/ImageMagick-6
PC_MagickWand_LDFLAGS:INTERNAL=-lMagickWand-6.Q16;-lMagickCore-6.Q16
PC_MagickWand_LDFLAGS_OTHER:INTERNAL=
PC_MagickWand_LIBDIR:INTERNAL=/usr/lib64
PC_MagickWand_LIBRARIES:INTERNAL=MagickWand-6.Q16;MagickCore-6.Q16
PC_MagickWand_LIBRARY_DIRS:INTERNAL=
PC_MagickWand_LIBS:INTERNAL=
PC_MagickWand_LIBS_L:INTERNAL=
PC_MagickWand_LIBS_OTHER:INTERNAL=
PC_MagickWand_LIBS_PATHS:INTERNAL=
PC_MagickWand_MagickWand_INCLUDEDIR:INTERNAL=
PC_MagickWand_MagickWand_LIBDIR:INTERNAL=
PC_MagickWand_MagickWand_PREFIX:INTERNAL=
PC_MagickWand_MagickWand_VERSION:INTERNAL=
PC_MagickWand_PREFIX:INTERNAL=/usr
PC_MagickWand_STATIC_CFLAGS:INTERNAL=-I/usr/include/ImageMagick-6;-fopenmp;-DMAGICKCORE_HDRI_ENABLE=0;-DMAGICKCORE_QUANTUM_DEPTH=16
PC_MagickWand_STATIC_CFLAGS_I:INTERNAL=
PC_MagickWand_STATIC_CFLAGS_OTHER:INTERNAL=-fopenmp;-DMAGICKCORE_HDRI_ENABLE=0;-DMAGICKCORE_QUANTUM_DEPTH=16
PC_MagickWand_STATIC_INCLUDE_DIRS:INTERNAL=/usr/include/ImageMagick-6
PC_MagickWand_STATIC_LDFLAGS:INTERNAL=-lMagickWand-6.Q16;-lMagickWand-6.Q16;-llcms2;-lfreetype;-lfftw3;-lxml2;-lfontconfig;-lfreetype;-lXext;-lSM;-lICE;-lX11;-lXt;-llzma;-lbz2;-lz;-lltdl;-lm;-lgomp;-lm;-lMagickCore-6.Q16;-lMagickCore-6.Q16;-llcms2;-lfreetype;-lfftw3;-lxml2;-lfontconfig;-lfreetype;-lXext;-lSM;-lICE;-lX11;-lXt;-llzma;-lbz2;-lz;-lltdl;-lm;-lgomp;-lm
PC_MagickWand_STATIC_LDFLAGS_OTHER:INTERNAL=
PC_MagickWand_STATIC_LIBDIR:INTERNAL=
PC_MagickWand_STATIC_LIBRARIES:INTERNAL=MagickWand-6.Q16;MagickWand-6.Q16;lcms2;freetype;fftw3;xml2;fontconfig;freetype;Xext;SM;ICE;X11;Xt;lzma;bz2;z;ltdl;m;gomp;m;MagickCore-6.Q16;MagickCore-6.Q16;lcms2;freetype;fftw3;xml2;fontconfig;freetype;Xext;SM;ICE;X11;Xt;lzma;bz2;z;ltdl;m;gomp;m
PC_MagickWand_STATIC_LIBRARY_DIRS:INTERNAL=
PC_MagickWand_STATIC_LIBS:INTERNAL=
PC_MagickWand_STATIC_LIBS_L:INTERNAL=
PC_MagickWand_STATIC_LIBS_OTHER:INTERNAL=
PC_MagickWand_STATIC_LIBS_PATHS:INTERNAL=
PC_MagickWand_VERSION:INTERNAL=6.9.9
__pkg_config_arguments_PC_Magick++:INTERNAL=QUIET;Magick++
__pkg_config_arguments_PC_MagickCore:INTERNAL=QUIET;MagickCore
__pkg_config_arguments_PC_MagickWand:INTERNAL=QUIET;MagickWand
__pkg_config_checked_PC_Magick++:INTERNAL=1
__pkg_config_checked_PC_MagickCore:INTERNAL=1
__pkg_config_checked_PC_MagickWand:INTERNAL=1 |
|
Fixed in #252 |
This was also reported to Ubuntu last year but seems to not have found its way here.
The text was updated successfully, but these errors were encountered: