Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

launch.py: Exit using sys.exit() #2409

Merged
merged 1 commit into from Nov 30, 2018

Conversation

ferdnyc
Copy link
Contributor

@ferdnyc ferdnyc commented Nov 29, 2018

cx_freeze doesn't like it if we quit OpenShot with exit(), triggering a traceback and complaining:

Traceback (most recent call last):
  File "/usr/local/lib/python3.4/dist-packages/cx_Freeze-4.3.4-py3.4-linux-x86_64.egg/cx_Freeze/initscripts/Console.py", line 27, in <module>
  File "openshot_qt/launch.py", line 105, in <module>
    main()
  File "openshot_qt/launch.py", line 76, in main
    exit()
NameError: name 'exit' is not defined

Using sys.exit() is more correct, and should appease cx_freeze.

cx_freeze doesn't like it if we quit OpenShot with `exit()`,
triggering a traceback and complaining:
```
Traceback (most recent call last):
  File "/usr/local/lib/python3.4/dist-packages/cx_Freeze-4.3.4-py3.4-linux-x86_64.egg/cx_Freeze/initscripts/Console.py", line 27, in <module>
  File "openshot_qt/launch.py", line 105, in <module>
    main()
  File "openshot_qt/launch.py", line 76, in main
    exit()
NameError: name 'exit' is not defined
```
Using `sys.exit()` is more correct, and should appease cx_freeze.
@peanutbutterandcrackers peanutbutterandcrackers merged commit 612c313 into OpenShot:develop Nov 30, 2018
@peanutbutterandcrackers
Copy link
Contributor

Thank you for making OpenShot better, as always.

@ferdnyc
Copy link
Contributor Author

ferdnyc commented Nov 30, 2018

Eh, in this case I was the one who made it worse in the first place. Those were my exit() statements that shouldn't have been there in the first place. 😆

@ferdnyc ferdnyc deleted the frozen-cmdline branch November 30, 2018 06:39
@peanutbutterandcrackers
Copy link
Contributor

Well, nobody's perfect. :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants