From 76a69d8f3bb5cbb5c5d9bd28b175e7fc4e2b06df Mon Sep 17 00:00:00 2001 From: prafull-opensignlabs Date: Mon, 30 Sep 2024 10:42:31 +0530 Subject: [PATCH] fix: enableOTP is not working correctly --- .../customRoute/v1/routes/CreateDocumentWithTemplate.js | 5 +++-- .../cloud/customRoute/v1/routes/updateDocument.js | 4 ++-- .../cloud/customRoute/v1/routes/updateTemplate.js | 2 +- 3 files changed, 6 insertions(+), 5 deletions(-) diff --git a/apps/OpenSignServer/cloud/customRoute/v1/routes/CreateDocumentWithTemplate.js b/apps/OpenSignServer/cloud/customRoute/v1/routes/CreateDocumentWithTemplate.js index ec344b130..b0a46e603 100644 --- a/apps/OpenSignServer/cloud/customRoute/v1/routes/CreateDocumentWithTemplate.js +++ b/apps/OpenSignServer/cloud/customRoute/v1/routes/CreateDocumentWithTemplate.js @@ -196,8 +196,9 @@ export default async function createDocumentWithTemplate(request, response) { if (TimeToCompleteDays) { object.set('TimeToCompleteDays', TimeToCompleteDays); } - const enableOTP = request.body?.enableOTP === true ? true : false; - const IsEnableOTP = enableOTP || template?.IsEnableOTP || false; + const enableOTP = request.body?.enableOTP; + const IsEnableOTP = + enableOTP !== undefined ? enableOTP : template?.IsEnableOTP || false; object.set('IsEnableOTP', IsEnableOTP); object.set('CreatedBy', template.CreatedBy); object.set('ExtUserPtr', { diff --git a/apps/OpenSignServer/cloud/customRoute/v1/routes/updateDocument.js b/apps/OpenSignServer/cloud/customRoute/v1/routes/updateDocument.js index 81a3fa5d3..f2ea62ce6 100644 --- a/apps/OpenSignServer/cloud/customRoute/v1/routes/updateDocument.js +++ b/apps/OpenSignServer/cloud/customRoute/v1/routes/updateDocument.js @@ -48,10 +48,10 @@ export default async function updateDocument(request, response) { objectId: request?.body?.folderId, }); } - - if (request.body?.enableOTP) { + if (request.body?.enableOTP !== undefined) { updateQuery.set('IsEnableOTP', request.body?.enableOTP); } + const updatedRes = await updateQuery.save(null, { useMasterKey: true }); if (updatedRes) { if (request.posthog) { diff --git a/apps/OpenSignServer/cloud/customRoute/v1/routes/updateTemplate.js b/apps/OpenSignServer/cloud/customRoute/v1/routes/updateTemplate.js index 735e699aa..87bbcf11b 100644 --- a/apps/OpenSignServer/cloud/customRoute/v1/routes/updateTemplate.js +++ b/apps/OpenSignServer/cloud/customRoute/v1/routes/updateTemplate.js @@ -48,7 +48,7 @@ export default async function updateTemplate(request, response) { objectId: request?.body?.folderId, }); } - if (request.body?.enableOTP) { + if (request.body?.enableOTP !== undefined) { updateQuery.set('IsEnableOTP', request.body?.enableOTP); } const updatedRes = await updateQuery.save(null, { useMasterKey: true });