Extended documentation traffic sign/road markings (resolves #229) (resolves #230) #231
Conversation
Remove doxygen windows bug (roadmarking types are not correct). Add StVO road markings as symbolic signs in documentation of traffic signs.
carsten-kuebler
added
the
Documentation
Add StVO no for symbolic traffic signs as road markings
osi_trafficsign.proto
Outdated
| // (StVO 211.1). Right: #TYPE_PRESCRIBED_RIGHT_WAY | ||
| // | ||
| // (StVO 211.1). Right: \c #TYPE_PRESCRIBED_RIGHT_WAY | ||
| // |
There was a problem hiding this comment.
Do we have a test checking for spaces before line break?
There was a problem hiding this comment.
No. I created unit tests mainly for errors. The space at the end of a line is more of an unwanted character and rather reduces the file size. A space at the end of a line doesn't cause an error, does it? Of course, it is very easy to add such an unit test. I suspect that every initial checkin will lead to an error with this unit test. Do we want to set up these high barriers for a check-in at GitHub?
I personally support unit tests. Should we add this unit test?
There was a problem hiding this comment.
Could you check for automatic style guide testing more in general? https://clang.llvm.org/docs/ClangFormat.html
There was a problem hiding this comment.
clang-format works for proto files, clang-check doesn't work for proto files (c,c++ works fine). We could use clang-format to reformat the files. Should we add active code-modification and github checkin via travis ci?
There was a problem hiding this comment.
yes, do we need a TravisCI user for that? The commit should be on the branch of the PR.
There was a problem hiding this comment.
Yes. We can use the same mechanism as for the auto-documentation. Drawback: We could end in an infinite loop 8-) of auto-check-ins.
ghost
merged commit 
Remove doxygen windows bug (roadmarking types are not correct).
Add StVO road markings as symbolic signs in documentation of traffic signs (resolves #229 and resolves #230 and additional road markings).