Add proto3 support via script to map file syntax #245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows usage of the OSI definitions on proto3 syntax, while remaining on-the-wire-compatible with the official proto2 syntax.
pmai
added
the
FeatureRequest
|
@HannesSchneiderAVL could you check if this fullfills your requirements, please? |
ghost
requested a review
from 
HannesSchneiderAVL
approved these changes
Jun 11, 2018
HannesSchneiderAVL
left a comment
HannesSchneiderAVL
left a comment
There was a problem hiding this comment.
Perfect, looks good for me!
ghost
approved these changes
Jun 11, 2018
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows usage of the OSI definitions on proto3 syntax,
while remaining on-the-wire-compatible with the official proto2
syntax.
Note that Travis CI build is also amended to build both proto2
and proto3 versions so that portability fails will be detected early.