Extended osi_trafficsign.proto with missing signs (fixes #261, fixes #241, fixes #281, fixes #219) #258

nikolavasiljevski · 2018-07-31T09:10:11Z

Added missing Main and Supplementary signs from StVO.
Used https://www.adac.de/_mmm/pdf/fi_verkehrszeichen_engl_infobr_0915_30482.pdf as base for adding new signs.
Also included addition sub-types found at : https://de.wikipedia.org/wiki/Bildtafel_der_Verkehrszeichen_in_der_Bundesrepublik_Deutschland_seit_2017

ghost

Hello Nikola, I finally finished my review.
It has taken some time to check all the numbers, the statements, the translation and the consistency. I hope this is helpfull. Regards, Ludwig

ghost · 2018-08-09T14:25:44Z

osi_trafficsign.proto

@@ -960,216 +960,2890 @@ message TrafficSign
                // See e.g.:
                //
                TYPE_TRAFFIC_LIGHT_GREEN_ARROW = 92;
+


Please remove every "ahead" in comments and enumerations. It's inconsistently used and doesn't possess additional value.
Please remove every "warning" in comments and enumerations. It's inconsistently used and doesn't possess additional value.
Please replace "banned" with "prohibited" in comments and enumerations.
Please replace "allowed" with "only" in enumerations (even if otherwise stated by me).

ghost · 2018-08-09T14:26:21Z

osi_trafficsign.proto

+                //
+                // See e.g.:
+                //
+                TYPE_LOOSE_CHIPPINGS = 97;


loose chipping -> loose gravel

ghost · 2018-08-09T14:26:57Z

osi_trafficsign.proto

+                //
+                // See e.g.:
+                //
+                TYPE_SWING_BRIDGE_AHEAD = 101;


swing bridge -> lifting bridge

ghost · 2018-08-09T14:27:48Z

osi_trafficsign.proto

+                //
+                // See e.g.: https://www.dvr.de/bilder/stvo/gt/142-10.png
+                //
+                TYPE_WILD_ANIMALS_CROSSING_WARNING_RIGHT = 113;


wild animal crossing -> deer crossing

ghost · 2018-08-09T14:27:59Z

osi_trafficsign.proto

+                //
+                // See e.g.:
+                //
+                TYPE_WILD_ANIMALS_CROSSING_WARNING_LEFT = 114;


wild animal crossing -> deer crossing

ghost · 2018-08-14T14:40:36Z

osi_trafficsign.proto

+                //
+                // See e.g.:
+                //
+                TYPE_FL


within marked parking areas only -> marked parking areas only

ghost · 2018-08-14T14:41:58Z

osi_trafficsign.proto

+                //
+                // See e.g.:
+                //
+                TYPE_FL


no parking on shoulder -> no waiting side stripes

ghost · 2018-08-14T14:43:53Z

osi_trafficsign.proto

+                //
+                // See e.g.:
+                //
+                TYPE_FL


also buses and cars with trailers ->cars trailer buses additionally

ghost · 2018-08-14T14:44:55Z

osi_trafficsign.proto

+                //
+                // See e.g.:
+                //
+                TYPE_FL


endangered area rabies -> rabies

ghost · 2018-08-14T14:46:10Z

osi_trafficsign.proto

+                //
+                // See e.g.:
+                //
+                TYPE_FL


endangered area wild animals rabies -> wild animals rabies

ghost

Hello Nikola, I finally finished my review.
It has taken some time to check all the numbers, the statements, the translation and the consistency. I hope this is helpfull. Regards, Ludwig

nikolavasiljevski

Hello Ludwig,

Thanks for the review, it was helpful.
I made all the changes suggested, will commit them after this review.
Also I added 3 comments, for further clarification.

Best Regards,
Nikola

Added missing Main and Supplementary signs from StVO. Used https://www.adac.de/_mmm/pdf/fi_verkehrszeichen_engl_infobr_0915_30482.pdf as base for adding new signs. Also included addition sub-types found at : https://de.wikipedia.org/wiki/Bildtafel_der_Verkehrszeichen_in_der_Bundesrepublik_Deutschland_seit_2017

- Fixed enum names - Types distinguished - Translation fixed - Extra signs removed - Enum values aligned

ghost

Why did you (re)append 'arrow'?

nikolavasiljevski · 2018-08-23T09:04:54Z

That was a mistake, sorry. I removed it.
I had some issues with duplicated enum names and when doxygen test failed, I automatically assumed that it was the case and added ARROW.

ghost

Hi Nikola,
I reviewed till line 3226. At that point, I realized the issues I pointed out in my last review were not adressed. Please check my first review,
Regards Ludwig

ghost · 2018-08-27T06:59:08Z

osi_trafficsign.proto

+                //
+                // See e.g.:
+                //
+                TYPE_RISK_OF_SHOW_OR_ICE = 94;


risk of show or ice -> snow or ice

ghost · 2018-08-27T07:06:18Z

osi_trafficsign.proto

+                //
+                // See e.g.: https://www.dvr.de/bilder/stvo/gt/156-10.png
+                //
+                TYPE_LEVER_CROSSING_COUNTDOWN_RIGHT = 118;


ghost · 2018-08-27T07:06:40Z

osi_trafficsign.proto

+                //
+                // See e.g.:
+                //
+                TYPE_LEVER_CROSSING_COUNTDOWN_LEFT = 119;


ghost · 2018-08-27T07:18:28Z

osi_trafficsign.proto

+                //
+                // See e.g.:
+                //
+                TYPE_MOPEDS_PROHIBITED = 155;


mopeds prohibited -> small mopeds prohibited

ghost · 2018-08-27T07:32:52Z

osi_trafficsign.proto

+                //
+                // See e.g.:
+                //
+                TYPE_PLACE_NAME_SIGN = 216;


place name sign -> place name

ghost · 2018-08-27T16:02:39Z

osi_trafficsign.proto

+                TYPE_ZONE = 20;
+
+                // Stop 4 way.
+                //


TYPE_KNOLL -> TYPE_HILLTOP

ghost · 2018-08-27T16:12:31Z

osi_trafficsign.proto

+                TYPE_ZONE = 20;
+
+                // Stop 4 way.
+                //


TYPE_WINTER_SPORTS_ALONG_THE_ROAD -> TYPE_WINTER_SPORTS

ghost · 2018-08-27T16:16:19Z

osi_trafficsign.proto

+                TYPE_ZONE = 20;
+
+                // Stop 4 way.
+                //


TYPE_LARGE_WAGONS_PARK_OVER_2_WEEKS -> TYPE_LONG-TERM_PARKING_TRAILERS

'-' is invalid character. I will use _ instead.

ghost · 2018-08-27T16:17:04Z

osi_trafficsign.proto

+                TYPE_ZONE = 20;
+
+                // Stop 4 way.
+                //


TYPE_CARAVAN_PARK_OVER_2_WEEKS -> TYPE_LONG-TERM_PARKING_CARAVANS

ghost · 2018-08-28T07:25:10Z

osi_trafficsign.proto

+                TYPE_ZONE = 20;
+
+                // Stop 4 way.
+                //


I think I already reviewed the following lines. Please check my first review.

Yes, I was changing Allowed to Only and I missed most of the comments for supplementary signs.
I went over them again and made changes.

ghost

Hi Nikola, that's it - I finished my second review.

Regards,
Ludwig

ghost · 2018-08-29T08:58:42Z

osi_trafficsign.proto

+
+                // Restriction of the validity of the traffic sign depending on
+                // the vehicle's weight (more than \c TrafficSignValue::value
+                // e.g. in kilogram - \c TrafficSignValue::valu


TYPE_DISABLED_PERSONS_PARKING_PERMIT_ALLOWED -> TYPE_DISABLED_PERSONS_PARKING_PERMIT_ONLY

ghost · 2018-08-29T08:59:44Z

osi_trafficsign.proto

+
+                // Restriction of the validity of the traffic sign depending on
+                // the vehicle's weight (more than \c TrafficSignValue::value
+                // e.g. in kilogram - \c TrafficSignValue::valu


TYPE_WINTER_SPORTS_ALLOWED -> TYPE_WINTER_SPORTS_ONLY

ghost · 2018-08-29T09:00:05Z

osi_trafficsign.proto

+
+                // Restriction of the validity of the traffic sign depending on
+                // the vehicle's weight (more than \c TrafficSignValue::value
+                // e.g. in kilogram - \c TrafficSignValue::valu


TYPE_RESIDENTS_ALLOWED -> TYPE_RESIDENTS_ONLY

ghost · 2018-08-29T09:00:47Z

osi_trafficsign.proto

+
+                // Restriction of the validity of the traffic sign depending on
+                // the vehicle's weight (more than \c TrafficSignValue::value
+                // e.g. in kilogram - \c TrafficSignValue::valu


TYPE_RESIDENTS_PARKING_ALLOWED -> TYPE_RESIDENTS_PARKING_ONLY

ghost · 2018-08-29T09:01:05Z

osi_trafficsign.proto

+
+                // Restriction of the validity of the traffic sign depending on
+                // the vehicle's weight (more than \c TrafficSignValue::value
+                // e.g. in kilogram - \c TrafficSignValue::valu


TYPE_RESIDENTS_PARKING_PERMIT_ALLOWED -> TYPE_RESIDENTS_PARKING_PERMIT_ONLY

ghost · 2018-08-31T10:41:18Z

osi_trafficsign.proto

+
+                // Restriction of the validity of the traffic sign depending on
+                // the vehicle's weight (more than \c TrafficSignValue::value
+                // e.g. in kilogram - \c TrafficSignValue::valu


TYPE_TAXI -> TYPE_TAXI_ONLY

ghost · 2018-08-31T10:41:48Z

osi_trafficsign.proto

+
+                // Restriction of the validity of the traffic sign depending on
+                // the vehicle's weight (more than \c TrafficSignValue::value
+                // e.g. in kilogram - \c TrafficSignValue::valu


TYPE_TAXI_QUANTITY -> TYPE_TAXI_QUANTITY_ONLY

ghost · 2018-08-31T10:42:15Z

osi_trafficsign.proto

+
+                // Restriction of the validity of the traffic sign depending on
+                // the vehicle's weight (more than \c TrafficSignValue::value
+                // e.g. in kilogram - \c TrafficSignValue::valu


TYPE_ELECTRIC_VEHICLES_CHARGING -> TYPE_ELECTRIC_VEHICLES_CHARGING_ONLY

ghost · 2018-08-31T10:42:58Z

osi_trafficsign.proto

+
+                // Restriction of the validity of the traffic sign depending on
+                // the vehicle's weight (more than \c TrafficSignValue::value
+                // e.g. in kilogram - \c TrafficSignValue::valu


TYPE_ELECTRIC_VEHICLES -> TYPE_ELECTRIC_VEHICLES_ONLY

ghost · 2018-08-31T10:45:08Z

osi_trafficsign.proto

+
+                // Restriction of the validity of the traffic sign depending on
+                // the vehicle's weight (more than \c TrafficSignValue::value
+                // e.g. in kilogram - \c TrafficSignValue::valu


TYPE_PARKING_TICKET -> TYPE_PARKING_TICKET_ONLY

ghost

Hi Nikola,
Looks good, thanks for your patience!

Regards,
Ludwig

carsten-kuebler · 2018-09-13T12:25:22Z

@LudwigFriedmannBMW @nikolavasiljevski
Hello Ludwig,

I checked the changes.

I would propose that:

Traffic signs e.g. 625 should use direction_scope and not two different enumerators TYPE_BEND_INDICATOR_LEFT = 308; TYPE_BEND_INDICATOR_RIGHT = 309;

I think Nikola changed the meaning of the supplementary signs:
For example
// Only motorcycles allowed.
//
TYPE_MOTORCYCLE_ALLOWED = 23;

        // Motorcycles only.
        // (StVO 1022-12).
        //
        // See e.g.:
        //
        TYPE_MOTORCYCLES_ONLY = 23;

The meaning of "Motorrad frei" is not "motorcycles only", it is "except motorcycles" and therefore "allowed for motorcycles".

If we change the names of enumerators, this PR could only be merged in V4.0.0

@LudwigFriedmannBMW shall we (TWT) modify the proposed PR?

ghost · 2018-09-13T12:33:16Z

Hi @carsten-kuebler,
translating the expression "frei" to "only" instead of "excluded" and merging these with "only" signs was my idea & fault.

Nevertheless, no existing enumerators should have been changed or overridden.

So this PR is an extension and may be integrated in OSI 3.1.0.

Please change the "frei" signs and the subtypes including a direction appropriately and merge the PR.

Regards,
Ludwig

carsten-kuebler · 2018-09-13T12:59:58Z

@LudwigFriedmannBMW We will also reorder the enumerators so that the enumerators would be ordered by the stvo number. We will give feedback if we have additional comments.

carsten-kuebler · 2018-10-11T12:12:54Z

@nikolavasiljevski and @LudwigFriedmannBMW

we have taken a look at the proposal by Nikola and have performed a number of corrections.

• Adjusted the ordering of the symbols: for the editor's convenience, we have resorted the symbols according to their StVO correspondence. Some entries cannot directly be sorted according to StVO. We have left those symbols at the end of the list and ordered with respect to their entry number (only for supplementary traffic signs). For main signs there are traffic signs without StVO to complete the list (e.g. U-turn left StVO 272, U-turn right not part of StVO).
• Eliminated some entries that were not part of the basic StVO and not relevant to the driving function (“Seuchengefahrhinweise”). See open question below.
• Edited some of the enumerator descriptions for additional understandability.
• Set plural names for actors: children, cars, taxis and so on.
• Merged entries that already existed with those that were newly introduced. Removed doubled definitions and used more detailed descriptions (adjusted entry numbers to previously defined values).
• Introduced a new comment at the end of the enumeration TYPE within Classification messages for both the MainSign and the SupplementarySign messages in which a counter called "last_counter" is introduced. This shows the highest value of the enumerators included and is thought to help in the processes of addition of new enumerators.
• We have merged the existing “TYPE_ZONE” with the newly proposed “TYPE_TRAFFIC_BAN_EXCEPTION_RED_YELLOW_GREEN “
• StVO 1010-12 “Long term parking trailers” and StVO 1010-13 “Long term parking caravans”. Seem to have a complete meaning by themselves. Additionally, they implicitly free from a parking constraint. Are they really supplementary signs/what is the main sign to these supplementary signs? Do we need to include the implicit semantic to the enumerator names (e.g. long term parking)?
• For the family StVO 315, replaced the word “FRONT” by “PERPENDICULAR” in the enumerator names.
• In some cases, such as the signs denoting „Electric Vehicles” (StVO 1010-66, 1050-33), there exist both a sign consisting of pure text and one of a pure image whereby only one semantic meaning is represented. We have merged these enumerators with one another in order to include the class representant only (similar to OSI 3.0).

carsten-kuebler · 2018-10-11T12:15:23Z

@LudwigFriedmannBMW

we are preparing a new version of the osi_trafficsign.proto file in which we would like to introduce the changes proposed next:
• Navigation guides: for StVO 157 to 162, the current implementation includes different entries according to the placement position of the rod, and to the number of stripes it has. We believe the required information is provided by a single type together with a single TrafficSignValue object (number of stripes, without unit, or the indicated distance with its units) as StVO 450. We would propose to reduce the number of enumerators. In contrast to StVO 450 the distance is optional.
• Time-restriction signs: Several signs of the family StVO 1042 and some of the family StVO 1040 can be modelled with the use of a few basic building blocks such as StVO 1040-30, 1042-30 and 1042-30, together with other already available objects (e.g. TrafficSignValues). Hence, we think it is not necessary to introduce one enumerator per member of the aforementioned family and would propose an adequate use of those modelling elements to achieve a more compact list of enumerators.
• Parking symbols: Symbols of the family StVO 315 can be conveniently grouped instead of adding one enumerator per family member.
• Symmetric symbols: Several symbols are symmetric and thus have an identical semantic, but are associated to different StVO-numbers, cf. StVO 117-10 and 117-20, StVO 134-10 and 134-20, StVO 133-10 and 133-20 and many others. We believe it not necessary to have all those symbols repeated several times in our proto-file and thus we propose the use of an optional direction indicator only when such a differentiation is strictly required.
• Symbols and strings: We would like to propose two improvements

we could model signs with an arbitrary text by introducing an adequate object to our TrafficSignValue message. This could importantly expand the standard’s flexibility and we would reduce the number of required enumerators.
we would introduce a second type, similar as for the message RoadMarking, which indicates if the traffic sign consists only of text, or only of a symbol. That would allow us to capture additional information about a given sign.

We have also found a mistake from our side. Namely, the one-way signs of family StVO 220 are better modelled by means of the DirectionScope element. This should be changed for the next version.

We also have an open question for further discussion
• Should further warning signs such as “Lights on” (see WH 55) be also included? (For reference see https://www.strassenausstatter.de/kategorie/verkehrszeichen/warnschilderundhinweisschilder/page/4/ )

ghost

As discussed with @carsten-kuebler TWT will reduce and simplify the set of signs

Add BASt images. Homogenized types.

carsten-kuebler · 2018-11-13T17:40:33Z

@CarloVanDriestenBMW please check the actual Version with all the Images from BASt. There are still a lot of main signs and supplementary signs. We should reduce the number of types, shouldn't we?

carsten-kuebler · 2018-11-13T17:46:11Z

Done:
• Navigation guides: for StVO 157 to 162, the current implementation includes different entries according to the placement position of the rod, and to the number of stripes it has. We believe the required information is provided by a single type together with a single TrafficSignValue object (number of stripes, without unit, or the indicated distance with its units) as StVO 450. We would propose to reduce the number of enumerators. In contrast to StVO 450 the distance is optional.
• Symmetric symbols: Several symbols are symmetric and thus have an identical semantic, but are associated to different StVO-numbers, cf. StVO 117-10 and 117-20, StVO 134-10 and 134-20, StVO 133-10 and 133-20 and many others. We believe it not necessary to have all those symbols repeated several times in our proto-file and thus we propose the use of an optional direction indicator only when such a differentiation is strictly required.

Additional:
• Add BASt images to OSI.

Open:
• Time-restriction signs: Several signs of the family StVO 1042 and some of the family StVO 1040 can be modelled with the use of a few basic building blocks such as StVO 1040-30, 1042-30 and 1042-30, together with other already available objects (e.g. TrafficSignValues). Hence, we think it is not necessary to introduce one enumerator per member of the aforementioned family and would propose an adequate use of those modelling elements to achieve a more compact list of enumerators.
• Parking symbols: Symbols of the family StVO 315 can be conveniently grouped instead of adding one enumerator per family member.
• Symbols and strings: We would like to propose two improvements
we could model signs with an arbitrary text by introducing an adequate object to our TrafficSignValue message. This could importantly expand the standard’s flexibility and we would reduce the number of required enumerators.
We would introduce a second type, similar as for the message RoadMarking, which indicates if the traffic sign consists only of text, or only of a symbol. That would allow us to capture additional information about a given sign.
We have also found a mistake from our side. Namely, the one-way signs of family StVO 220 are better modelled by means of the DirectionScope element. This should be changed for the next version.

We also have an open question for further discussion
• Should further warning signs such as “Lights on” (see WH 55) be also included? (For reference see https://www.strassenausstatter.de/kategorie/verkehrszeichen/warnschilderundhinweisschilder/page/4/ )

ghost · 2018-11-16T07:39:27Z

doc/images/BASt_2017/README.txt

+images in their original size can be downloaded directly 
+from (last query: 29 October 2018)
+
+https://www.bast.de/BASt_2017/DE/Verkehrstechnik/Fachthemen/v1-verkehrszeichen/vz-download.html


ghost · 2018-11-16T07:49:32Z

We decided that the reasoning for certain decission e.g. introducint the vertical_mirror should be included in the description as readers normally do not follow the discussions within the PRs od issues.

ghost · 2018-11-16T07:55:07Z

Optional: Add some more tests in python script and add clang

Update. Add Arrow and Actor to supplementary sign. Not added to main sign because of leading to too many depreciated types. Will be proposed to change in OSI 4.0.

Small changes in documentation. Change doxygen config file to use brief section.

ghost

build fail

carsten-kuebler · 2018-12-11T17:12:16Z

@CarloVanDriestenBMW Build Failed

$ python test_cases_doc.py
doc/html/structosi3_1_1EnvironmentalConditions.html in line 232: not permitted hash found. Search for: ' #AMBIENT_ILLUMINATION_LEVEL1
doc/html/structosi3_1_1EnvironmentalConditions.html in line 265: not permitted hash found. Search for: ' #AMBIENT_ILLUMINATION_LEVEL9

please update proto2cpp PR

carsten-kuebler · 2018-12-11T17:16:21Z

@CarloVanDriestenBMW I restart CI

Update documentation. Add "." at the end of a sentence.

carsten-kuebler · 2018-12-11T17:44:53Z

@CarloVanDriestenBMW Test is now ok. I add some hundred "." at the end of some sentences...

Re-Format of clang

ghost

Please check WARNING and DANGER prefixes for consistency.
As they're yet not present in all warning signs, and as all warning sign enums make perfect sense without theses prefixes, in my opinion, they can be removed.

ghost · 2018-12-12T11:28:40Z

osi_trafficsign.proto

@@ -418,7 +418,7 @@ message TrafficSign
                //
                TYPE_SNOW_OR_ICE = 94;


DANGER is missing here.
I'd propose to handle this consistently and thuss remove DANGER from all types

ghost · 2018-12-12T11:30:21Z

osi_trafficsign.proto

@@ -458,7 +458,7 @@ message TrafficSign
                //
                TYPE_DANGER_MOVABLE_BRIDGE = 101;


Shouldn't this be LIFTING_BRIDGE?

Is ist always lifting? Some rotate etc.

Well, the sign depicts a lifting bridge and it's named lifting bridge.

I am actually a litle bit on the side of "generic expression including all kinds of moving bridges". I would assume that the "moving" part is what is relevant for the function. In the end all different signs for "moving bridges" can be expressed with one type?

ghost · 2018-12-12T11:32:54Z

osi_trafficsign.proto

@@ -468,7 +468,7 @@ message TrafficSign
                //
                TYPE_RIGHT_BEFORE_LEFT_NEXT_INTERSECTION = 3;


In the following defines, DANGER is missing again.
I'd propose to handle this consistently and thuss remove DANGER from all types.

ghost · 2018-12-12T11:36:56Z

osi_trafficsign.proto

@@ -579,7 +579,7 @@ message TrafficSign
                //
                TYPE_WARNING_ROAD_NARROWING = 10;


Now WARNING steps in for DANGER.
Where's the difference? Is there any criterion to distinguish warning and danger?
Again, I would propose to remove it.

ghost · 2018-12-12T11:38:49Z

osi_trafficsign.proto

@@ -902,7 +902,7 @@ message TrafficSign
                //
                TYPE_PRESCRIBED_STRAIGHT_AHEAD = 22;


TYPE_PRESCRIBED_STRAIGHT would be sufficient.

ghost · 2018-12-12T11:39:38Z

osi_trafficsign.proto

@@ -933,11 +933,11 @@ message TrafficSign
                //
                // As symbolic road marking
                // \c RoadMarking::Classification::TYPE_SYMBOLIC_TRAFFIC_SIGN
-                // (StVO 297)
+                // (StVO 297).
                //
                TYPE_PRESCRIBED_RIGHT_TURN_AND_STRAIGHT_AHEAD = 26;


Again, please remove AHEAD

ghost · 2018-12-12T11:39:53Z

osi_trafficsign.proto

@@ -948,11 +948,11 @@ message TrafficSign
                //
                // As symbolic road marking
                // \c RoadMarking::Classification::TYPE_SYMBOLIC_TRAFFIC_SIGN
-                // (StVO 297)
+                // (StVO 297).
                //
                TYPE_PRESCRIBED_LEFT_TURN_AND_STRAIGHT_AHEAD = 25;


Again, please remove AHEAD

ghost · 2018-12-12T11:40:11Z

osi_trafficsign.proto

@@ -971,11 +971,11 @@ message TrafficSign
                //
                // As symbolic road marking
                // \c RoadMarking::Classification::TYPE_SYMBOLIC_TRAFFIC_SIGN
-                // (StVO 297)
+                // (StVO 297).
                //
                TYPE_PRESCRIBED_LEFT_TURN_RIGHT_TURN_AND_STRAIGHT_AHEAD = 28;


Again, please remove AHEAD

ghost · 2018-12-12T11:45:53Z

osi_trafficsign.proto

@@ -2124,7 +2119,7 @@ message TrafficSign
                //
                TYPE_TRAFFIC_CALMED_DISTRICT_BEGIN = 77;


Is there a better translation?

ghost · 2018-12-12T11:46:08Z

osi_trafficsign.proto

@@ -2135,7 +2130,7 @@ message TrafficSign
                // Begin: \c #TYPE_TRAFFIC_CALMED_DISTRICT_BEGIN
                TYPE_TRAFFIC_CALMED_DISTRICT_END = 78;


Is there a better translation?

Living Street?
https://en.wikipedia.org/wiki/Living_street

If it is the official name according to Wikipedai -> Go for it :)

ghost · 2018-12-12T12:19:19Z

I guess the inconsistency is "TYPE_DANGER_FALLING_ROCKS" , "TYPE_SNOW_OR_ICE", "TYPE_ROAD_WORK", "TYPE_WARNING_ROAD_NARROWING_LEFT " maybe it can just be altered in the 4.0.0

I added a comment in the corresponding issue

ghost · 2018-12-12T12:20:15Z

Please ignore my comments if they affect types that were not introduced within this PR.

Update documentation. Unify zebra crossing

carsten-kuebler · 2018-12-14T11:22:41Z

@LudwigFriedmannBMW: type names has changed for OSI 3.1. Names are consistent as ypu proposed.
@CarloVanDriestenBMW: Minor release: binary compatibility requried. Src. code compatibility is not granted.

Use styleguide for comments

All included

nikolavasiljevski force-pushed the master branch from 3ef4431 to 2f92207 Compare July 31, 2018 09:36

ghost mentioned this pull request Aug 3, 2018

Extension of German traffic signs and supplementary signs (StVO) #261

Closed

ghost changed the title ~~Extended osi_trafficsign.proto with missing signs~~ Extended osi_trafficsign.proto with missing signs fixes #261 Aug 3, 2018

ghost added the FeatureRequest Proposals which enhance the interface or add additional features. label Aug 6, 2018

ghost added this to the v3.1.0 milestone Aug 6, 2018

ghost changed the title ~~Extended osi_trafficsign.proto with missing signs fixes #261~~ Extended osi_trafficsign.proto with missing signs fixes #261 fixes #241 Aug 6, 2018

ghost suggested changes Aug 14, 2018

View reviewed changes

ghost reviewed Aug 14, 2018

View reviewed changes

nikolavasiljevski commented Aug 21, 2018

View reviewed changes

Nikola Vasiljevski added 2 commits August 21, 2018 18:04

Fixed review issues

7216769

- Fixed enum names - Types distinguished - Translation fixed - Extra signs removed - Enum values aligned

nikolavasiljevski force-pushed the master branch from 69fbeaa to 7216769 Compare August 22, 2018 11:25

Fixed doxygen issue

e3c8e92

ghost suggested changes Aug 23, 2018

View reviewed changes

Removed added ARROW by mistake

cc413a5

ghost suggested changes Aug 28, 2018

View reviewed changes

Added review changes

6b0ac47

ghost suggested changes Aug 31, 2018

View reviewed changes

Fixed review comments

90576a8

ghost approved these changes Aug 31, 2018

View reviewed changes

Merge branch 'master' into master

b203ad4

This was referenced Sep 26, 2018

TrafficSign::MainSign::Classification::value is not represent #272

Open

Text-oriented Traffic Signs #219

Closed

Sign 625 guide sign in bends #223

Closed

Sign 439 direction sign (announcement) #222

Closed

Sign 332 motorway exit announcement #221

Closed

ghost suggested changes Oct 23, 2018

View reviewed changes

Unification

019d619

Add BASt images. Homogenized types.

ghost suggested changes Nov 16, 2018

View reviewed changes

Traffic sign rework

9591619

Update. Add Arrow and Actor to supplementary sign. Not added to main sign because of leading to too many depreciated types. Will be proposed to change in OSI 4.0.

carsten-kuebler mentioned this pull request Dec 9, 2018

Complex Main Traffic Signs #292

Open

carsten-kuebler and others added 2 commits December 9, 2018 18:14

Update Documentation

494bfb8

Small changes in documentation. Change doxygen config file to use brief section.

Merge branch 'master' into master

727c771

ghost suggested changes Dec 10, 2018

View reviewed changes

Update osi_trafficsign.proto

8ed0cf5

Update documentation. Add "." at the end of a sentence.

Update osi_trafficsign.proto

95a93cd

Re-Format of clang

ghost previously requested changes Dec 12, 2018

View reviewed changes

Update Documentation

73b341f

Update documentation. Unify zebra crossing

Update documentation

143a57a

Use styleguide for comments

ghost changed the title ~~Extended osi_trafficsign.proto with missing signs fixes #261 fixes #241~~ Extended osi_trafficsign.proto with missing signs (fixes #261, fixes #241, fixes #281) Dec 14, 2018

ghost changed the title ~~Extended osi_trafficsign.proto with missing signs (fixes #261, fixes #241, fixes #281)~~ Extended osi_trafficsign.proto with missing signs (fixes #261, fixes #241, fixes #281, fixes #219) Dec 14, 2018

ghost approved these changes Dec 14, 2018

View reviewed changes

ghost merged commit ce92c01 into OpenSimulationInterface:master Dec 14, 2018

This pull request was closed.

		@@ -418,7 +418,7 @@ message TrafficSign
		//
		TYPE_SNOW_OR_ICE = 94;

		@@ -458,7 +458,7 @@ message TrafficSign
		//
		TYPE_DANGER_MOVABLE_BRIDGE = 101;

		@@ -468,7 +468,7 @@ message TrafficSign
		//
		TYPE_RIGHT_BEFORE_LEFT_NEXT_INTERSECTION = 3;

		@@ -579,7 +579,7 @@ message TrafficSign
		//
		TYPE_WARNING_ROAD_NARROWING = 10;

		@@ -902,7 +902,7 @@ message TrafficSign
		//
		TYPE_PRESCRIBED_STRAIGHT_AHEAD = 22;

		@@ -2124,7 +2119,7 @@ message TrafficSign
		//
		TYPE_TRAFFIC_CALMED_DISTRICT_BEGIN = 77;

		@@ -2135,7 +2130,7 @@ message TrafficSign
		// Begin: \c #TYPE_TRAFFIC_CALMED_DISTRICT_BEGIN
		TYPE_TRAFFIC_CALMED_DISTRICT_END = 78;

Extended osi_trafficsign.proto with missing signs (fixes #261, fixes #241, fixes #281, fixes #219) #258

Extended osi_trafficsign.proto with missing signs (fixes #261, fixes #241, fixes #281, fixes #219) #258

Uh oh!

Conversation

nikolavasiljevski commented Jul 31, 2018

Uh oh!

ghost left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ghost left a comment

Choose a reason for hiding this comment

Uh oh!

nikolavasiljevski left a comment

Choose a reason for hiding this comment

Uh oh!

ghost left a comment

Choose a reason for hiding this comment

Uh oh!

nikolavasiljevski commented Aug 23, 2018

Uh oh!

ghost left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nikolavasiljevski Aug 28, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ghost left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nikolavasiljevski Aug 28, 2018 •

edited

Loading

ghost commented Sep 13, 2018 •

edited by ghost

Loading