Speed up CI builds through better usage of caching #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
merged commit 
mbinna
reviewed
Feb 13, 2017
| CMAKE_URL="https://cmake.org/files/v3.7/cmake-3.7.2-Linux-x86_64.tar.gz" | ||
| mkdir -p cmake | ||
| travis_retry wget --no-check-certificate --quiet -O - ${CMAKE_URL} | tar --strip-components=1 -xz -C cmake | ||
| if [ ! -f ${DEPS_DIR}/cmake/bin/cmake ] ; then mkdir -p cmake ; travis_retry wget --no-check-certificate --quiet -O - ${CMAKE_URL} | tar --strip-components=1 -xz -C cmake ; fi |
Contributor
There was a problem hiding this comment.
@pmai Is there a reason you did not introduce newline characters after 120 characters? At the moment, users have to horizontally scroll. Same in line 35.
Contributor
Author
There was a problem hiding this comment.
Mostly just to keep the build log files less verbose.
mbinna
reviewed
Feb 13, 2017
| cd protobuf | ||
| ./configure --prefix=/usr | ||
| make | ||
| if [ ! -f ${DEPS_DIR}/protobuf/src/.libs/protoc ] ; then mkdir -p protobuf ; travis_retry wget --no-check-certificate --quiet -O - ${PROTOBUF_URL} | tar --strip-components=1 -xz -C protobuf ; cd protobuf ; ./configure --prefix=/usr ; make ; else cd protobuf ; fi |
Contributor
There was a problem hiding this comment.
The dot in ${DEPS_DIR}/protobuf/src/.libs/protoc looks strange. Did you intentionally add it?
Contributor
Author
There was a problem hiding this comment.
Yes, the actual binary is built in the .libs directory, the other protoc is just a wrapper script and therefore not really indicative of a completed build.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves CI Cache usage by not redownloading/rebuilding dependencies when they are already in the cache. Also removes need for cache updates after build.