Add shared lib target, rename static lib (fix #55) #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code using multiple copies of the static libraries in one process can cause problems due to multiple copies of the protobuffer libraries not interacting correctly. Change default target library to be a shared library, add static variant as _static, and use object libraries to optimize the building of the shared and _pic static libraries.
ghost
added
the
FeatureRequest
ghost
requested review from
PhilippRoethigBMW
approved these changes
Mar 23, 2017
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code using multiple copies of the static libraries in one process can
cause problems due to multiple copies of the protobuffer libraries not
interacting correctly. Change default target library to be a shared
library, add static variant as _static, and use object libraries to
optimize the building of the shared and _pic static libraries.