Skip to content

Version number in one file (resolves #58) #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
3 commits merged into from
Apr 4, 2017
Merged

Version number in one file (resolves #58) #64

3 commits merged into from
Apr 4, 2017

Conversation

@AhmedMzid
Copy link
Contributor

@AhmedMzid AhmedMzid commented Apr 4, 2017

  • The version number will only have to be defined in the new file VERSION
  • cmake and setup.py parse the file VERSION and set global variables which define the version number.
  • The message InterfaceVersion is now defined in osi_version.proto.in which will be configured by cmake/setup.py with the suitable version number.

@AhmedMzid AhmedMzid requested a review from a user April 4, 2017 07:01
ghost
ghost approved these changes Apr 4, 2017
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Work!

@ghost ghost merged commit e8549a1 into master Apr 4, 2017
@pmai pmai deleted the feature/version-number branch January 18, 2018 12:12
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AhmedMzid @PhilippRoethigBMW