Fix default exclusion of gitignore directory #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #9 Signed-off-by: Pierre R. Mai <pmai@pmsf.de>
|
OSI CCB 16.10.25: Approved, but merging pending enough memebers to test. Shall be merged offline by 1 of the CCB members |
thomassedlmayer
approved these changes
Oct 16, 2025
Contributor
thomassedlmayer
left a comment
thomassedlmayer
left a comment
There was a problem hiding this comment.
pip install . and poetry run pip install . works now again for me on Windows. Also, it works to reference this branch in the pyproject.toml of another project and install it via poetry install as dependency.
poetry install in osi-python itself does still create empty osi3 and osi3trace lib folders but that's not to be solved by this PR.
Contributor
|
The installation using pip from remote (without cloning) works as well.
Should this be tracked in a new issue? |
TimmRuppert
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9