New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please consider setting ServiceCollectionExtensions to public #99

Closed
beckjin opened this Issue Oct 28, 2018 · 4 comments

Comments

Projects
None yet
3 participants
@beckjin
Contributor

beckjin commented Oct 28, 2018

If it's public, we can install SkyWalking. Agent. AspNetCore via the nuget package, use services.AddSkyWalkingCore () in ConfigureServices.

default

public void ConfigureServices(IServiceCollection services)
{
	services.AddSkyWalkingCore();
	services.AddMvc().SetCompatibilityVersion(CompatibilityVersion.Version_2_1);
}
@wu-sheng

This comment has been minimized.

Member

wu-sheng commented Oct 28, 2018

You could send a pull request and ask project team to review. That is easier way to provide feature.

@beckjin

This comment has been minimized.

Contributor

beckjin commented Oct 29, 2018

OK

@beckjin beckjin referenced this issue Oct 29, 2018

Merged

Set ServiceCollectionExtensions to public #100

1 of 3 tasks complete
@liuhaoyang

This comment has been minimized.

Member

liuhaoyang commented Oct 29, 2018

Install SkyWalking.Agent.AspNetCore package, then add the assembly name of SkyWalking.Agent.AspNetCore to the ASPNETCORE_HOSTINGSTARTUPASSEMBLIES environment variable.

@beckjin

This comment has been minimized.

Contributor

beckjin commented Oct 29, 2018

Of course, this is a way.

@liuhaoyang liuhaoyang closed this Oct 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment