/opensmalltalk-vm

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JIT failing testMediumIntegerDiv and testMediumIntegerRem #6

Closed
rmacnak opened this Issue Jun 20, 2016 · 4 comments

Comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@rmacnak @timfel @eliotmiranda
@rmacnak
Member

rmacnak commented Jun 20, 2016

From Newspeak's KernelTestsConfiguration, these tests pass on the stack VM but fail on the JIT.

assert: minInt31 // -1 equals: 1073741824.
Equality assertion failed; expected: 1073741824, was: -1073741824

assert: (minInt31 rem: -1) equals: 0.
Equality assertion failed; expected: 0, was: -2147483648
@timfel

This comment has been minimized.

Sign in to view
Member

timfel commented Jun 20, 2016

I think we should include running some tests in a CI job also. Right now we're just testing if it compiles ("regression testing"? What's that? If it compiles, it is good -http://lkml.iu.edu/hypermail/linux/kernel/9804.1/0149.html)
@eliotmiranda

This comment has been minimized.

Sign in to view
Contributor

eliotmiranda commented Jul 5, 2016

Ryan, I think this is fixed. I could close or could leave it up to you to verify.
@rmacnak

This comment has been minimized.

Sign in to view
Member

rmacnak commented Jul 7, 2016

I can verify this is fixed in Monticello, but not in Git. Leaving the issue open until the fix lands here.
@rmacnak

This comment has been minimized.

Sign in to view
Member

rmacnak commented Aug 7, 2016

Fixed by a8e42ed.

@rmacnak rmacnak closed this Aug 7, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment