Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress rtprio warning when ${CI} env var is set #279

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
2 participants
@fniephaus
Copy link
Member

commented Aug 19, 2018

This makes the rtprio warning less verbose when the ${CI} env var is set.
${CI} is usually set by common CI providers, see:

"pthread_setschedparam failed: Operation not permitted" is still printed to inform about the misconfiguration.

If no one objects, I will merge this in the next couple of days...

Closes #275

@akgrant43

This comment has been minimized.

Copy link
Contributor

commented Aug 19, 2018

Hi Fabio,

I think using a CI environment variable to control the output of
warnings is less than ideal:

  • It is doing double duty with a variable, which is never a good idea.

  • If I'm running a CI that does allow rtprio and I want the warning, I
    have to write the non-obvious script to unset the environment
    variable.

  • If I'm running some other production environment and want to suppress
    the warning I have to do something like:

export CI "this is a ugly hack to make smalltalk suppress one warning"
squeak/pharo some.image

Either of:

--suppress-rtprio-warning # previously suggested

or

--suppress list,of,warnings

as command line options is a better approach. We have CI specific
scripts which can do the appropriate thing.

Cheers,
Alistair

@fniephaus

This comment has been minimized.

Copy link
Member Author

commented Aug 19, 2018

@akgrant43 I agree, a command line flag is nice and this was just a practical "hack". As I mentioned, the "pthread_setschedparam failed: Operation not permitted" error is still displayed, it's just the "how to fix it" that I tried to suppress here.
I'd like to see that flag implemented soon, but I'm afraid I don't have enough time to work on it (if you know how the option parse work, it should be much work. I just haven't touched that code yet).

@fniephaus fniephaus closed this Aug 19, 2018

@akgrant43

This comment has been minimized.

Copy link
Contributor

commented Aug 19, 2018

Hi @fniephaus ,

Thanks for the clarification.

Cheers,
Alistair

@fniephaus fniephaus deleted the suppress-rtprio-warning branch Aug 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.