From f0456e0582bb230048afcc08792e028040a32248 Mon Sep 17 00:00:00 2001 From: "Ankur Sinha (Ankur Sinha Gmail)" Date: Thu, 17 Jul 2025 16:02:46 +0100 Subject: [PATCH 1/3] chore: bump dev to 0.3.10 --- setup.cfg | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/setup.cfg b/setup.cfg index 972589a..6d6e513 100644 --- a/setup.cfg +++ b/setup.cfg @@ -1,6 +1,6 @@ [metadata] name = OSBModelValidation -version = 0.3.9 +version = 0.3.10 author = Boris Marin, Padraig Gleeson author_email = borismarin@gmail.com url = https://github.com/OpenSourceBrain/osb-model-validation From 3a335138553b1180fb8f4955a36a57a07a961bd2 Mon Sep 17 00:00:00 2001 From: Padraig Gleeson Date: Fri, 18 Jul 2025 17:59:49 +0100 Subject: [PATCH 2/3] Add test on issue with: omv all -V --engine=jNeuroML_NEURON --- .github/workflows/ci_versions.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci_versions.yml b/.github/workflows/ci_versions.yml index 22b6a46..5345fcc 100644 --- a/.github/workflows/ci_versions.yml +++ b/.github/workflows/ci_versions.yml @@ -44,7 +44,7 @@ jobs: - name: Run simple OMV tests run: | - omv install pyNeuroML + omv all -V --engine=jNeuroML_NEURON omv test -V utilities/tests/.test.exIzh.jnmlnetpyne.omt From 97e27e97bf4e307594b5bd9ad37f3ea2a01225bd Mon Sep 17 00:00:00 2001 From: Padraig Gleeson Date: Fri, 18 Jul 2025 18:00:03 +0100 Subject: [PATCH 3/3] Add fix --- omv/engines/jneuroml.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/omv/engines/jneuroml.py b/omv/engines/jneuroml.py index 5f4883e..eaa8129 100644 --- a/omv/engines/jneuroml.py +++ b/omv/engines/jneuroml.py @@ -16,7 +16,7 @@ def get_environment(): if "JNML_HOME" in os.environ: jnmlhome = os.environ["JNML_HOME"] elif shutil.which(JNeuroMLEngine.e_name) is not None: - jnmlhome = Path(shutil.which(JNeuroMLEngine.e_name)).parent + jnmlhome = str(Path(shutil.which(JNeuroMLEngine.e_name)).parent) else: jnmlhome = ""