Use 24 hour windows in OWM WeatherProvider

OpenSprinkler · May 13, 2019 · 0a75b3d · 0a75b3d
1 parent e175028
commit 0a75b3d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/routes/weather.ts b/routes/weather.ts
@@ -174,7 +174,8 @@ function checkWeatherRestriction( adjustmentValue: number, weather: WateringData
 
 	if ( californiaRestriction ) {
 
-		// TODO this is currently checking if the forecasted precipitation over the next 30 hours is >0.1 inches
+		// TODO depending on which WeatherProvider is used, this might be checking if rain is forecasted in th next 24
+		// 	hours rather than checking if it has rained in the past 48 hours.
 		// If the California watering restriction is in use then prevent watering
 		// if more then 0.1" of rain has accumulated in the past 48 hours
 		if ( weather.precip > 0.1 ) {

diff --git a/routes/weatherProviders/OWM.ts b/routes/weatherProviders/OWM.ts
@@ -23,7 +23,7 @@ async function getOWMWateringData( coordinates: GeoCoordinates ): Promise< Water
 	  totalHumidity = 0,
 	  totalPrecip = 0;
 
-	const periods = Math.min(forecast.list.length, 10);
+	const periods = Math.min(forecast.list.length, 8);
 	for ( let index = 0; index < periods; index++ ) {
 		totalTemp += parseFloat( forecast.list[ index ].main.temp );
 		totalHumidity += parseInt( forecast.list[ index ].main.humidity );