Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return raw data used to calculate watering level #19

Merged
merged 1 commit into from May 4, 2019

Conversation

Projects
None yet
3 participants
@Derpthemeus
Copy link
Member

commented May 4, 2019

No description provided.

@salbahra salbahra merged commit 1d70ed0 into OpenSprinkler:master May 4, 2019

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
@PeteBa

This comment has been minimized.

Copy link
Contributor

commented May 4, 2019

Great stuff. Two suggestions:

  • Can we add weather.raining to the return values as a "0" or "1" so that we know if rain delay has kicked in
  • We should Math.round(x*10)/10 the temp value and Math.round(x*100)/100 the precip value to avoid a bunch of least significant values and bloat of the firmware buffer
@Derpthemeus

This comment has been minimized.

Copy link
Member Author

commented May 5, 2019

Good ideas, I'll implement both of those changes

@Derpthemeus

This comment has been minimized.

Copy link
Member Author

commented May 5, 2019

Suggestions addressed in #20

@Derpthemeus Derpthemeus deleted the Derpthemeus:return-raw-data branch May 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.