Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ETo AdjustmentMethod #62

Merged
merged 5 commits into from Jun 20, 2019

Conversation

Projects
None yet
4 participants
@Derpthemeus
Copy link
Member

commented Jun 11, 2019

No description provided.

Derpthemeus added some commits Jun 11, 2019

@PeteBa
Copy link
Contributor

left a comment

Matt, a quick download as I know this PR has been up for a while.

Show resolved Hide resolved routes/adjustmentMethods/EToAdjustmentMethod.ts
Show resolved Hide resolved routes/adjustmentMethods/EToAdjustmentMethod.ts Outdated
Show resolved Hide resolved routes/adjustmentMethods/EToAdjustmentMethod.ts
Show resolved Hide resolved routes/adjustmentMethods/EToAdjustmentMethod.ts
Show resolved Hide resolved routes/adjustmentMethods/EToAdjustmentMethod.ts
Show resolved Hide resolved routes/adjustmentMethods/EToAdjustmentMethod.ts Outdated
Show resolved Hide resolved routes/adjustmentMethods/EToAdjustmentMethod.ts
Show resolved Hide resolved routes/adjustmentMethods/EToAdjustmentMethod.ts Outdated
Show resolved Hide resolved routes/adjustmentMethods/EToAdjustmentMethod.ts Outdated
Show resolved Hide resolved test/etoTest.json Outdated
@rmloeb

This comment has been minimized.

Copy link

commented Jun 18, 2019

Trying to follow the discussion regarding "base ETo"... Is the concept that watering times in OS would be set by the user to align with base ETo and the adjustment would increase/decrease in proportion to the ratio of actualEto/baseETo?

@Derpthemeus

This comment has been minimized.

Copy link
Member Author

commented Jun 18, 2019

@rmloeb That is correct

@rmloeb

This comment has been minimized.

Copy link

commented Jun 18, 2019

Thank you. I'm trying to think this through from the perspective of an OS user. Does the reference (base) ETo for a specific location change throughout the year? For a specific location, is there a "standard" value?

I appreciate that OS needs a starting point. Zimmerman does that by establishing a "default" day, e.g., average temperature 70 degrees, average humidity 30%, and 0 precipitation and uses the variance from that default to set water level. I'm trying to understand how your ETo calculation is going to be actually be used. (We don't want something that is just as difficult as Zimmerman to understand for a practical application.)

@Derpthemeus

This comment has been minimized.

Copy link
Member Author

commented Jun 18, 2019

The baseline ETo the user specifies should be chosen such that on a day where the ETo is equal to the baseline ETo, a scale of 100% will achieve the desired watering level. If the user changes their watering schedule with the seasons or is only watering crops for a few months, they should use the average ETo for that timespan; if they use the same watering schedule year-round, they should use the average daily ETo for a full year.

@rmloeb

This comment has been minimized.

Copy link

commented Jun 19, 2019

Your logic is quite sensible and the way that farmers do it (and they have equipment to actually measure ETo). If you compute it hourly, then you would need to average it for the day, as you do for temperature and humidity, presumably reaching the same result. (I'm basing this on the assumption that you are actually deriving water level for the next day, not the current day, which is consistent with my comment about ignoring whether it is currently raining..)

@PeteBa

PeteBa approved these changes Jun 19, 2019

Copy link
Contributor

left a comment

Matt, suggest merge and move on.

@PeteBa PeteBa self-assigned this Jun 19, 2019

@Derpthemeus Derpthemeus merged commit 2c40ace into OpenSprinkler:eto Jun 20, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Derpthemeus Derpthemeus deleted the Derpthemeus:add-eto-adjustment-method branch Jun 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.