Skip to content

Feature/otp service refactor #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
smarcet merged 6 commits into from
May 11, 2026
Merged

Feature/otp service refactor #130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1abf069
chore: refactor OTP logic
smarcet May 9, 2026
1cb21b4
refactor(auth): drop $should_create_user flag from verifyOTPChallenge
smarcet May 10, 2026
8392dea
fix(auth): close validate→redeem race in OTP finalization
smarcet May 11, 2026
a0406ff
feat(auth): bind verifyOTPChallenge to the session user
smarcet May 11, 2026
c225a47
refactor(auth): drop unused OAuth2OTP transient $user field
smarcet May 11, 2026
94d0419
test(auth): cover already-redeemed race-fix branch in verifyOTPChallenge
smarcet May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion app/Models/OAuth2/OAuth2OTP.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -498,5 +498,4 @@ public function getUserId()
{
return $this->user_id;
}

}
6 changes: 6 additions & 0 deletions app/Repositories/DoctrineOAuth2OTPRepository.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,4 +138,10 @@ public function getByValueConnectionAndUserName
->setMaxResults(1)
->getOneOrNullResult();
}

public function refreshExclusiveLock(OAuth2OTP $otp): void
{
// Single round-trip: SELECT ... FOR UPDATE that also re-hydrates the entity.
$this->getEntityManager()->refresh($otp, \Doctrine\DBAL\LockMode::PESSIMISTIC_WRITE);
}
}
Loading
Loading