Skip to content

Add -no-verify-emitted-module-interface #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kyle-Ye merged 1 commit into from
May 11, 2025
Merged

Add -no-verify-emitted-module-interface #114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/workflows/compatibility_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,6 @@ jobs:
- name: Swift version
run: swift --version
- name: Run tests against Apple's AttributeGraph on macOS via SwiftPM
env:
OPENGRAPH_LIBRARY_EVOLUTION: 0
run: |
swift test \
--build-path .build-compatibility-test-debug
Expand Down
4 changes: 0 additions & 4 deletions .github/workflows/macos.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,6 @@ jobs:
- name: Swift version
run: swift --version
- name: Build and run tests in debug mode with coverage
env:
OPENGRAPH_LIBRARY_EVOLUTION: 0
run: |
swift test \
-c debug \
Expand All @@ -47,8 +45,6 @@ jobs:
.build-test-debug/debug/OpenGraphPackageTests.xctest/Contents/MacOS/OpenGraphPackageTests \
> coverage.txt
- name: Build and run tests in release mode
env:
OPENGRAPH_LIBRARY_EVOLUTION: 0
run: |
swift test \
-c release \
Expand Down
5 changes: 3 additions & 2 deletions Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,8 +119,9 @@ let libraryEvolutionCondition = envEnable("OPENGRAPH_LIBRARY_EVOLUTION")
#endif

if libraryEvolutionCondition {
// NOTE: -enable-library-evolution is not supported on `swift build` yet.
sharedSwiftSettings.append(.unsafeFlags(["-enable-library-evolution"]))
// NOTE: -enable-library-evolution will cause module verify failure for `swift build`.
// Either set OPENGRAPH_LIBRARY_EVOLUTION=0 or add `-Xswiftc -no-verify-emitted-module-interface` after `swift build`
sharedSwiftSettings.append(.unsafeFlags(["-enable-library-evolution", "-no-verify-emitted-module-interface"]))
}

// MARK: - Targets
Expand Down
6 changes: 3 additions & 3 deletions Scripts/og_swiftinterface.sh → Scripts/build_swiftinterface.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ filepath() {
[[ $1 = /* ]] && echo "$1" || echo "$PWD/${1#./}"
}

OG_ROOT="$(dirname $(dirname $(filepath $0)))"
OPENGRAPH_ROOT="$(dirname $(dirname $(filepath $0)))"

cd $OG_ROOT
cd $OPENGRAPH_ROOT

swift build -Xswiftc -emit-module-interface -Xswiftc -enable-library-evolution
swift build -Xswiftc -emit-module-interface -Xswiftc -enable-library-evolution -Xswiftc -no-verify-emitted-module-interface