Skip to content

Fix StackLayout's sizeChildrenGenerallyWithConcreteMajorProposal implementation #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 6, 2025
Merged

Fix StackLayout's sizeChildrenGenerallyWithConcreteMajorProposal implementation #369

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
07286c3
Fix StackLayout's sizeChildrenGenerallyWithConcreteMajorProposal impl…
Kyle-Ye Jul 6, 2025
2486d86
Add StackLayout's prioritize support
Kyle-Ye Jul 6, 2025
e7fcebd
Update update for StackLayout
Kyle-Ye Jul 6, 2025
dacdf2b
Update resize implementation for StackLayout
Kyle-Ye Jul 6, 2025
5837b14
Update commitPlacements to handle layoutDirection
Kyle-Ye Jul 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 22 additions & 9 deletions Example/OpenSwiftUIUITests/Layout/Stack/HVStackUITests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,11 +144,9 @@ struct HVStackUITests {
.background { Color.black }
}
}
withKnownIssue("Proposal implmentation is not correct") {
openSwiftUIAssertSnapshot(
of: ContentView()
)
}
openSwiftUIAssertSnapshot(
of: ContentView()
)
}

@Test
Expand All @@ -166,10 +164,25 @@ struct HVStackUITests {
.background { Color.black }
}
}
withKnownIssue("Proposal implmentation is not correct") {
openSwiftUIAssertSnapshot(
of: ContentView()
)
openSwiftUIAssertSnapshot(
of: ContentView()
)
}

@Test("Verify red and blue should have the same size")
func sameSizeInVStack() {
struct ContentView: View {
var body: some View {
VStack(spacing: 20) {
Color.red
Color.yellow
.frame(width: 10, height: 10)
Color.blue
}
}
}
openSwiftUIAssertSnapshot(
of: ContentView()
)
}
}
Loading