Skip to content

Update OpenGraph dependency for comparison API #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 12, 2025
Merged

Update OpenGraph dependency for comparison API #383

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Package.resolved
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Sources/OpenSwiftUICore/Data/Environment/EnvironmentKeyTransformModifier.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ private struct ChildEnvironment<Value>: StatefulRule, AsyncAttribute, CustomStri
modifier.transform(&newValue)
}
guard !environmentChanged,
let valueChanged = oldValue.map({ compareValues($0, newValue, mode: ._2) }), !valueChanged,
let valueChanged = oldValue.map({ compareValues($0, newValue, mode: .equatableUnlessPOD) }), !valueChanged,
let keyPathChanged = oldKeyPath.map({ $0 == keyPath }), !keyPathChanged,
hasValue
else {
Expand Down
2 changes: 1 addition & 1 deletion Tests/OpenSwiftUICoreTests/Data/Environment/EnvironmentKeyTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ struct EnvironmentKeyTests {
#expect(OptionalStringEnvironmentKey._valuesEqual(nil, "test") == false)
}

#if canImport(Darwin) // FIXME: compareValues is not implemented on OG yet
#if OPENGRAPH_ATTRIBUTEGRAPH // FIXME: compareValues is not implemented on OG yet
@Test
func nonEquatableValuesComparison() {
let struct1 = CustomStructEnvironmentKey.CustomStruct(value: 100)
Expand Down