From efb09d6eedd4b30a56581093cb9f1d9e366e5632 Mon Sep 17 00:00:00 2001 From: Kyle Date: Sat, 20 Sep 2025 12:36:47 +0800 Subject: [PATCH 1/2] Add test case to track the known bugs --- .../Geometry/GeometryReaderUITests.swift | 9 ++++++- .../Modifier/InsetViewModifierUITests.swift | 24 +++++++++++++++++++ 2 files changed, 32 insertions(+), 1 deletion(-) create mode 100644 Example/OpenSwiftUIUITests/Layout/Modifier/InsetViewModifierUITests.swift diff --git a/Example/OpenSwiftUIUITests/Layout/Geometry/GeometryReaderUITests.swift b/Example/OpenSwiftUIUITests/Layout/Geometry/GeometryReaderUITests.swift index 38563db42..ba7ef2ee4 100644 --- a/Example/OpenSwiftUIUITests/Layout/Geometry/GeometryReaderUITests.swift +++ b/Example/OpenSwiftUIUITests/Layout/Geometry/GeometryReaderUITests.swift @@ -8,7 +8,7 @@ import Testing @MainActor @Suite(.snapshots(record: .never, diffTool: diffTool)) struct GeometryReaderUITests { - @Test + @Test(.bug("https://github.com/OpenSwiftUIProject/OpenSwiftUI/issues/474")) func centerView() { struct ContentView: View { var body: some View { @@ -24,6 +24,13 @@ struct GeometryReaderUITests { } } openSwiftUIAssertSnapshot(of: ContentView()) + #if OPENSWIFTUI + withKnownIssue { + openSwiftUIAssertSnapshot(of: ContentView(), as: .image) + } + #else + openSwiftUIAssertSnapshot(of: ContentView(), as: .image) + #endif } @Test diff --git a/Example/OpenSwiftUIUITests/Layout/Modifier/InsetViewModifierUITests.swift b/Example/OpenSwiftUIUITests/Layout/Modifier/InsetViewModifierUITests.swift new file mode 100644 index 000000000..4d172e09b --- /dev/null +++ b/Example/OpenSwiftUIUITests/Layout/Modifier/InsetViewModifierUITests.swift @@ -0,0 +1,24 @@ +// +// InsetViewModifierUITests.swift +// OpenSwiftUIUITests + +import Testing + +struct InsetViewModifierUITests { + @Test(.bug("https://github.com/OpenSwiftUIProject/OpenSwiftUI/issues/511")) + func safeAreaPaddingWithEdgeInsets() { + struct ContentView: View { + var body: some View { + Color.red + .safeAreaPadding(.init(top: 10, leading: 20, bottom: 30, trailing: 40)) + } + } + #if OPENSWIFTUI + withKnownIssue { + openSwiftUIAssertSnapshot(of: ContentView(), as: .image) + } + #else + openSwiftUIAssertSnapshot(of: ContentView(), as: .image) + #endif + } +} From 8dd1952ee10f8cfd3390c38037997d22ed7c1845 Mon Sep 17 00:00:00 2001 From: Kyle Date: Sun, 21 Sep 2025 12:53:46 +0800 Subject: [PATCH 2/2] Fix test case issue --- .../Layout/Geometry/GeometryReaderUITests.swift | 2 ++ .../Layout/Modifier/InsetViewModifierUITests.swift | 5 +++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/Example/OpenSwiftUIUITests/Layout/Geometry/GeometryReaderUITests.swift b/Example/OpenSwiftUIUITests/Layout/Geometry/GeometryReaderUITests.swift index ba7ef2ee4..a2783e0b2 100644 --- a/Example/OpenSwiftUIUITests/Layout/Geometry/GeometryReaderUITests.swift +++ b/Example/OpenSwiftUIUITests/Layout/Geometry/GeometryReaderUITests.swift @@ -24,6 +24,7 @@ struct GeometryReaderUITests { } } openSwiftUIAssertSnapshot(of: ContentView()) + #if os(iOS) #if OPENSWIFTUI withKnownIssue { openSwiftUIAssertSnapshot(of: ContentView(), as: .image) @@ -31,6 +32,7 @@ struct GeometryReaderUITests { #else openSwiftUIAssertSnapshot(of: ContentView(), as: .image) #endif + #endif } @Test diff --git a/Example/OpenSwiftUIUITests/Layout/Modifier/InsetViewModifierUITests.swift b/Example/OpenSwiftUIUITests/Layout/Modifier/InsetViewModifierUITests.swift index 4d172e09b..727f7193c 100644 --- a/Example/OpenSwiftUIUITests/Layout/Modifier/InsetViewModifierUITests.swift +++ b/Example/OpenSwiftUIUITests/Layout/Modifier/InsetViewModifierUITests.swift @@ -4,6 +4,7 @@ import Testing +@MainActor struct InsetViewModifierUITests { @Test(.bug("https://github.com/OpenSwiftUIProject/OpenSwiftUI/issues/511")) func safeAreaPaddingWithEdgeInsets() { @@ -15,10 +16,10 @@ struct InsetViewModifierUITests { } #if OPENSWIFTUI withKnownIssue { - openSwiftUIAssertSnapshot(of: ContentView(), as: .image) + openSwiftUIAssertSnapshot(of: ContentView()) } #else - openSwiftUIAssertSnapshot(of: ContentView(), as: .image) + openSwiftUIAssertSnapshot(of: ContentView()) #endif } }