Skip to content

Update DynamicProperty implementation to 6.5.4 #524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 1, 2025
Merged

Update DynamicProperty implementation to 6.5.4 #524

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a8caafc
Update DynamicProperty and add addTreeValue API
Kyle-Ye Oct 1, 2025
39e864c
Update DynamicPropertyCache and fix known issues
Kyle-Ye Oct 1, 2025
0e8e4af
Add DynamicPropertyCacheTests
Kyle-Ye Oct 1, 2025
b664d02
Update missing parts of DynamicProperty
Kyle-Ye Oct 1, 2025
7dc70b5
Disable DynamicPropertyCacheTests on OAG
Kyle-Ye Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions Sources/OpenSwiftUICore/Data/Combine/ObservedObject.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
// OpenSwiftUICore
//
// Audited for 6.5.4
// Status: Blocked by addTreeValueSlow
// Status: Complete
// ID: C212C242BFEB175E53A59438AB276A7C (SwiftUICore)

import OpenAttributeGraphShims
Expand Down Expand Up @@ -222,7 +222,13 @@ extension ObservedObject {
invalidation: WeakAttribute(attribute)
)
buffer.append(box, fieldOffset: fieldOffset)
// TODO: addTreeValueSlow
addTreeValue(
attribute,
as: ObjectType.self,
at: fieldOffset,
in: Value.self,
flags: .observedObjectSignal
)
}
}

Expand Down
Loading
Loading