Skip to content

Fix HostingExample storyboard settings for mac destinations#897

Merged
Kyle-Ye merged 2 commits into
mainfrom
bugfix/macos_example
Jun 7, 2026
Merged

Fix HostingExample storyboard settings for mac destinations#897
Kyle-Ye merged 2 commits into
mainfrom
bugfix/macos_example

Conversation

@Kyle-Ye

@Kyle-Ye Kyle-Ye commented Jun 7, 2026

Copy link
Copy Markdown
Member

Closes #896

Summary

  • Restrict HostingExample storyboard Info.plist keys to iOS and visionOS SDKs.
  • Include HostingExample/Base.lproj storyboard resources only for iOS and visionOS destinations.

Why

HostingExample applies iOS storyboard configuration to mac destinations. Xcode then reports that LaunchScreen.storyboard and Main.storyboard do not support target device type "mac".

Validation

  • Ran Example/setup.sh.
  • Confirmed Tuist generated Example.xcworkspace successfully.
  • Opened the generated workspace for manual inspection.

@github-actions github-actions Bot added area: example Example apps, previews, sample projects, screenshots, or demo assets. platform: macOS macOS-specific behavior or support. type: bug Something is not working correctly. labels Jun 7, 2026
@codecov

codecov Bot commented Jun 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 26.71%. Comparing base (ded2a87) to head (b2d617d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #897      +/-   ##
==========================================
+ Coverage   26.70%   26.71%   +0.01%     
==========================================
  Files         697      697              
  Lines       48907    48907              
==========================================
+ Hits        13061    13067       +6     
+ Misses      35846    35840       -6     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Kyle-Ye Kyle-Ye marked this pull request as ready for review June 7, 2026 13:38
@Kyle-Ye Kyle-Ye merged commit fb8f421 into main Jun 7, 2026
8 checks passed
@Kyle-Ye Kyle-Ye deleted the bugfix/macos_example branch June 7, 2026 13:38
@augmentcode

augmentcode Bot commented Jun 7, 2026

Copy link
Copy Markdown
🤖 Augment PR Summary

Summary: Restricts HostingExample storyboard-related Info.plist settings and storyboard resources to iOS/visionOS builds so mac destinations no longer fail due to unsupported storyboard target device types.

🤖 Was this summary useful? React with 👍 or 👎

@augmentcode augmentcode Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 1 suggestion posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

"revision" : "6675bc0ff86e61436e615df6fc5174e043e57924",
"version" : "1.4.1"
"revision" : "fea17c02d767f46b23070fdfdacc28a03a39232a",
"version" : "1.5.1"

@augmentcode augmentcode Bot Jun 7, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This bumps swift-collections from 1.4.1 to 1.5.1; since the PR is focused on storyboard settings, can you confirm this dependency update is intentional (and needed) rather than an incidental change from regenerating files?

Severity: low

Other Locations
  • Example/Example_Legacy.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved:2

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: example Example apps, previews, sample projects, screenshots, or demo assets. platform: macOS macOS-specific behavior or support. type: bug Something is not working correctly.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HostingExample reports iOS storyboard errors for mac destination

1 participant