Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Query string decoding fails sometimes #152

Closed
tsuna opened this Issue Jan 30, 2013 · 4 comments

Comments

Projects
None yet
3 participants
Owner

tsuna commented Jan 30, 2013

For instance hitting /q?start=2013/01/29-11:00:00&end=2013/01/29-14:00:00&m=sum:rate:proc.net.bytes&o=&yformat=%25.0s%25cB%2Fs&yrange=[0:] causes a redirection to /#start=2013/01/29-11:00:00&end=2013/01/29-14:00:00&m=sum:rate:proc.net.bytes&o=&yformat=%25.0s%25cB%2Fs&yrange=[0:] which causes an uncaught JavaScript exception Uncaught URIError: URI malformed when the URL fragment gets decoded to rebuild the state of the UI.

I've spotted errors like that too (when I played around with getting data out via cURL/node.js), but I couldn't narrow it down to any particular detail that made it freak out.

Owner

tsuna commented Jan 30, 2013

I assume the bug is either in tsd/client/QueryString.java or in some place that misuses this class.

Contributor

isavin commented Feb 4, 2013

Removing "&yformat=%25.0s%25cB%2Fs" or urlencoding the value one more time "yformat=%2525.0s%2525cB%252Fs" seems to resolve the issue.

Contributor

isavin commented Feb 4, 2013

Attempted to fix the issue in #155

@tsuna tsuna closed this in 00d40cf Feb 8, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment