Add global annotations to graphs #773

Closed
HugoMFernandes opened this Issue Apr 15, 2016 · 2 comments

Projects

None yet

2 participants

@HugoMFernandes
Contributor

GraphHandler is currently not retrieving (or setting) global annotations when these are requested. All graphs ignore the queryParam "&global_annotations" and the gnuplot result is always missing the vertical lines (as it isn't retrieved or set).

I've fixed this (PR to follow) in GraphHandler.java because the codebase is actually handling queries differently in GraphHandler.java and QueryRpc.java (the code in GraphHandler is actually synchronous right now). In my opinion, both GraphHandler.java and QueryRpc.java should be refactored to separate query logic from the actual visualization (and thus, share the query logic code), but that's a much larger piece of work (we should probably open an issue for this).

@HugoMFernandes HugoMFernandes added a commit to HugoMFernandes/opentsdb that referenced this issue Apr 15, 2016
@HugoMFernandes HugoMFernandes Fix #773 - Add global_annotations to graphs
Fixed a bug in which global_annotations were ignored by
GraphHandler.java (and thus, were not rendered by gnuplot). Added async
call to hbase to retrieve global annotations when required in a similar
fashion as that of QueryRpc.java.

Note: Since both GraphHandler.java and QueryRpc.java implement (similar)
query-processing logic, all of this should be unified in the future
(requires a large refactor to split all query logic with visualization
logic).
8bb0a90
@johann8384
Member

Go ahead and open the issue for that, and I will take a look at this ASAP.

Thank you!
On Apr 15, 2016 9:09 AM, "HugoMFernandes" notifications@github.com wrote:

GraphHandler is currently not retrieving (or setting) global annotations
when these are requested. All graphs ignore the queryParam
"&global_annotations" and the gnuplot result is always missing the vertical
lines (as it isn't retrieved or set).

I've fixed this (PR to follow) in GraphHandler.java because the codebase
is actually handling queries differently in GraphHandler.java and
QueryRpc.java (the code in GraphHandler is actually synchronous right now).
In my opinion, both GraphHandler.java and QueryRpc.java should be
refactored to separate query logic from the actual visualization (and thus,
share the query logic code), but that's a much larger piece of work (we
should probably open an issue for this).


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#773

@HugoMFernandes
Contributor

Done (#775) and submitted PR for this one (#774). Cheers!

@manolama manolama added a commit to manolama/opentsdb that referenced this issue Apr 23, 2016
@HugoMFernandes @manolama HugoMFernandes + manolama Fix #773 - Add global_annotations to graphs
Fixed a bug in which global_annotations were ignored by
GraphHandler.java (and thus, were not rendered by gnuplot). Added async
call to hbase to retrieve global annotations when required in a similar
fashion as that of QueryRpc.java.

Note: Since both GraphHandler.java and QueryRpc.java implement (similar)
query-processing logic, all of this should be unified in the future
(requires a large refactor to split all query logic with visualization
logic).
07ff47e
@manolama manolama added a commit that closed this issue Apr 23, 2016
@HugoMFernandes @manolama HugoMFernandes + manolama Fix #773 - Add global_annotations to graphs
Fixed a bug in which global_annotations were ignored by
GraphHandler.java (and thus, were not rendered by gnuplot). Added async
call to hbase to retrieve global annotations when required in a similar
fashion as that of QueryRpc.java.

Note: Since both GraphHandler.java and QueryRpc.java implement (similar)
query-processing logic, all of this should be unified in the future
(requires a large refactor to split all query logic with visualization
logic).

Signed-off-by: Chris Larsen <clarsen@yahoo-inc.com>
539e4b0
@manolama manolama closed this in 539e4b0 Apr 23, 2016
@manolama manolama added a commit to manolama/opentsdb that referenced this issue Apr 23, 2016
@HugoMFernandes @manolama HugoMFernandes + manolama Fix #773 - Add global_annotations to graphs
Fixed a bug in which global_annotations were ignored by
GraphHandler.java (and thus, were not rendered by gnuplot). Added async
call to hbase to retrieve global annotations when required in a similar
fashion as that of QueryRpc.java.

Note: Since both GraphHandler.java and QueryRpc.java implement (similar)
query-processing logic, all of this should be unified in the future
(requires a large refactor to split all query logic with visualization
logic).
9f75c97
@manolama manolama added a commit that referenced this issue Apr 23, 2016
@HugoMFernandes @manolama HugoMFernandes + manolama Fix #773 - Add global_annotations to graphs
Fixed a bug in which global_annotations were ignored by
GraphHandler.java (and thus, were not rendered by gnuplot). Added async
call to hbase to retrieve global annotations when required in a similar
fashion as that of QueryRpc.java.

Note: Since both GraphHandler.java and QueryRpc.java implement (similar)
query-processing logic, all of this should be unified in the future
(requires a large refactor to split all query logic with visualization
logic).

Signed-off-by: Chris Larsen <clarsen@yahoo-inc.com>
3d55806
@johann8384 johann8384 added a commit to johann8384/opentsdb that referenced this issue Dec 5, 2016
@HugoMFernandes @johann8384 HugoMFernandes + johann8384 Fix #773 - Add global_annotations to graphs
Fixed a bug in which global_annotations were ignored by
GraphHandler.java (and thus, were not rendered by gnuplot). Added async
call to hbase to retrieve global annotations when required in a similar
fashion as that of QueryRpc.java.

Note: Since both GraphHandler.java and QueryRpc.java implement (similar)
query-processing logic, all of this should be unified in the future
(requires a large refactor to split all query logic with visualization
logic).

Signed-off-by: Chris Larsen <clarsen@yahoo-inc.com>
e3ff79b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment