Why was support for creating metadata from the /api/uid/tsmeta endpoint removed in 2.2? #778

Closed
sgarg7 opened this Issue Apr 18, 2016 · 6 comments

Projects

None yet

2 participants

@sgarg7
sgarg7 commented Apr 18, 2016

This is a question. From the docs at http://opentsdb.net/docs/build/html/api_http/uid/tsmeta.html, the ability to create new tsmeta objects via the api was removed in OpenTSDB 2.2.
Now the only way to create metadata objects is to rely on metasync, which needs to scan the whole database. Having this endpoint would have been a convenience. What were the reasons for making this change? Isn't it a breaking change for the API?

@manolama manolama added the bug label May 1, 2016
@manolama
Member
manolama commented May 1, 2016

You're right it is a breaking change and I probably shouldn't have made it. I think the thought was that we shouldn't have a meta object for a series that doesn't exist. I'll double check and restore it for 2.2.1.

@sgarg7
sgarg7 commented May 1, 2016

That would be great. Thank you for the reply.
On Sun, May 1, 2016 at 2:05 PM Chris Larsen notifications@github.com
wrote:

You're right it is a breaking change and I probably shouldn't have made
it. I think the thought was that we shouldn't have a meta object for a
series that doesn't exist. I'll double check and restore it for 2.2.1.


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#778 (comment)

@manolama manolama added a commit to manolama/opentsdb that referenced this issue May 1, 2016
@manolama manolama Fix issue #778 by allowing the creating of a TSMeta object without
a TSUID.
Also fix up some UTs in the UIDRPC class where the JSON order can
change.
199e266
@manolama manolama added a commit to manolama/opentsdb that referenced this issue May 1, 2016
@manolama manolama Fix issue #778 by allowing the creating of a TSMeta object without
a TSUID.
Also fix up some UTs in the UIDRPC class where the JSON order can
change.
a4cc4fc
@manolama manolama added a commit that referenced this issue May 1, 2016
@manolama manolama Fix issue #778 by allowing the creating of a TSMeta object without
a TSUID.
Also fix up some UTs in the UIDRPC class where the JSON order can
change.

Signed-off-by: Chris Larsen <clarsen@yahoo-inc.com>
d951c8b
@manolama manolama added a commit that referenced this issue May 1, 2016
@manolama manolama Fix issue #778 by allowing the creating of a TSMeta object without
a TSUID.
Also fix up some UTs in the UIDRPC class where the JSON order can
change.

Signed-off-by: Chris Larsen <clarsen@yahoo-inc.com>
091a4c2
@manolama
Member
manolama commented May 1, 2016

Restored in d951c8b

@manolama manolama closed this May 1, 2016
@sgarg7
sgarg7 commented May 3, 2016

@manolama By the way, I wanted to make sure that the issue is not only about the creation of tsmeta objects without existing UIDs or series, but the creation of any tsmeta objects from the endpoint, including for existing series.

@sgarg7
sgarg7 commented May 3, 2016

@manolama I also wanted to know if you will keep this feature in future versions. It is a useful feature for us because it reduces our dependence on metasync which takes a long time since it has to scan the whole database.

@manolama
Member
manolama commented May 3, 2016

Ah, I don't think it will create the entry if one or more of the UIDs have not been assigned. That's something to test (if you have a sec to try it I'd appreciate it). But yeah, I think it would be fine to keep it around long-term. Just need to update the documentation now.

@johann8384 johann8384 added a commit to johann8384/opentsdb that referenced this issue Dec 5, 2016
@manolama @johann8384 manolama + johann8384 Fix issue #778 by allowing the creating of a TSMeta object without
a TSUID.
Also fix up some UTs in the UIDRPC class where the JSON order can
change.

Signed-off-by: Chris Larsen <clarsen@yahoo-inc.com>
c9fbf64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment