New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3x tweaks #1440

Closed
wants to merge 4 commits into
base: 3.0
from

Conversation

Projects
None yet
3 participants
@manolama
Member

manolama commented Dec 1, 2018

No description provided.

manolama added some commits Dec 1, 2018

CORE:
- Store the UID LRU cache size as a metric as well.
CORE:
- Add support for auto downsampling based on the query interval. The various
  intervals are configurable as well.
@coveralls

This comment has been minimized.

coveralls commented Dec 1, 2018

Coverage Status

Coverage increased (+0.09%) to 60.67% when pulling e89fecc on manolama:3x_tweaks into f0ef643 on OpenTSDB:3.0.

PARENT:
- Remove the old build files since we use Maven now.

@manolama manolama force-pushed the manolama:3x_tweaks branch from a4aaaaa to 2ac604d Dec 1, 2018

@SeanPMiller

This comment has been minimized.

SeanPMiller commented Dec 1, 2018

Per discussion, removing all unneeded files from the old build system is a good idea.

@SeanPMiller

Looks good to me. Suggestions at most.

* @return The non-null intervals list.
*/
public List<Pair<Long, String>> autoIntervals() {
return intervals;

This comment has been minimized.

@SeanPMiller

SeanPMiller Dec 1, 2018

You could ensure no modification by returning an immutable view.

// all good, sync it. Ugly yeah but this should run infrequently and only
// have up to a dozen entries.
synchronized (intervals) {

This comment has been minimized.

@SeanPMiller

SeanPMiller Dec 1, 2018

Seeing synchronized draws my attention. Investigated. Don't see any big problems here...

DIST:
- Update the distribution with a dev.yaml that uses the in-memory mock DB
  and a default config for the HBase connection.
@manolama

This comment has been minimized.

Member

manolama commented Dec 1, 2018

Merged in 2ee4d3a

@manolama manolama closed this Dec 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment