Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3x tweaks #1568

wants to merge 7 commits into from


None yet
3 participants
Copy link

commented Mar 25, 2019

No description provided.

manolama added some commits Mar 20, 2019

- Move TimeShift from the old code to the new base. We'll fix it up and rename it next.
- Add an offset interval config to TimeSeriesDataSourceConfig

- Implement TimeShift and now MockDataStore supports it.
  TODO - add to HBase and Bigtable.
- Add an hasBeenSetup() method to the TimeSeriesDataSourceConfig.

- Fix up the factories to set this flag as it's cleaner.
- Support time offsets.
- Fix toBuilder() in MergerConfig.
- Add time shifts to Bigtable.
- Add a setTimeShifts() builder to the TimeSeriesDataSourceConfig interface so
  we can pass down specific configs.

- Fix an NPE bug in AbstractQueryPipelineContext where a data source may come
  through that we didn't have a counter for.
- Remove has_been_setup from HAClusterConfig, don't need it.
- Tweak HAClusterFActory to support time offsets.
- Don't push down TimeShiftConfig for now. TODO - revisit this.

- Tweak it to support time offsets by stripping the interval when we match an
  ID in the offsets map.

@manolama manolama force-pushed the manolama:3x_tweaks branch from ad0ee9d to 596c064 Mar 26, 2019

Copy link

left a comment

Push it!

Copy link

left a comment

Took a fair amount of thought. I didn't come up with a meaningfully better way to approach the problem. Looks fine.

next =;
amounts = Maps.newHashMap();

// TODO - must be easier/cleaner ways.

This comment has been minimized.

Copy link

SeanPMiller Mar 26, 2019

When it comes to datetime, nothing is easy or clean.


This comment has been minimized.

Copy link
Member Author

commented Mar 26, 2019

Merged in 95e389a

@manolama manolama closed this Mar 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.