Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Remove English part of description for Chinese townnames GRF #76

merged 1 commit into from Jan 23, 2021


Copy link

@LordAro LordAro commented Jan 23, 2021

To bring it under the length limit of 511, due to incoming better validation of text lengths (OpenTTD/bananas-api#80)

English part removed since the townnames are in Chinese, you're unlikely to want them unless you can read Chinese.

@zbx1425 's Chinese True Town Names

Copy link

Basically, despite the fact you could enter it in BaNaNaS, in-game it would never render that much text, and it would be cut-off in the middle somewhere. The validation is now a lot better, but does mean this package violates the length limit for description. This PR fixes that, but at the loss of some english text.

The original author can fix this again via BaNaNaS, in case our call was unjust :)

@TrueBrain TrueBrain merged commit 7f34c4e into master Jan 23, 2021
@TrueBrain TrueBrain deleted the description-length branch January 23, 2021 13:47
Copy link

zbx1425 commented Jan 23, 2021

Never noticed the length limit in game before 😂
I'll replace it with a shorter Chinese description later...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants