Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit checker always expect origin/master, even for non master PRs #29

Closed
glx22 opened this issue Mar 8, 2019 · 3 comments
Closed

Commit checker always expect origin/master, even for non master PRs #29

glx22 opened this issue Mar 8, 2019 · 3 comments

Comments

@glx22
Copy link
Contributor

@glx22 glx22 commented Mar 8, 2019

For backports we open PRs against origin/release/XXX but commit checker assumes origin/master, and fails.

@TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented Mar 9, 2019

Two possible solutions I can think of:

  1. Assume we use Azure Pipelines, and check for the "System.PullRequest.TargetBranch" variable to know the tracking branch.
  2. allow an optional additional parameter with the tracking branch, and set that via the CI.

Most likely the second is nicer.

@glx22
Copy link
Contributor Author

@glx22 glx22 commented Mar 9, 2019

In Azure Pipelines docker task parameters for run command there is

envVarsEnvironment variables (Optional) Environment variables for the Docker container. Specify each name-value pair on a new line.

So second solution should not be too difficult. And maybe SYSTEM_PULLREQUEST_TARGETBRANCH is already passed without needing to use envVars parameter.

@TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented Mar 9, 2019

No clue what I was smocking earlier today, but I think it would be good if these Dockers don't know about Azure. But yeah, mapping the variable in via env is fine. Extra parameter, env variable .. tomato tomato :)

glx22 added a commit to glx22/CompileFarm that referenced this issue Mar 10, 2019
@TrueBrain TrueBrain closed this in a65d03f Mar 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.