Skip to content
This repository has been archived by the owner. It is now read-only.

Add: handle the new pull_request_review actions #12

merged 1 commit into from Oct 6, 2018


Copy link

@TrueBrain TrueBrain commented Oct 6, 2018

No description provided.

@@ -26,6 +26,18 @@
message = f"{['user']} reopened pull request #{['pull_id']}: {['title']}"
elif["action"] == "comment":
message = f"{['user']} commented on pull request #{['pull_id']}: {['title']}"
elif["action"] == "dismissed":
message = f"{['user']} dismissed the approval of pull request #{['pull_id']}:" \
Copy link

@LordAro LordAro Oct 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not necessarily an approval that was dismissed - s/approval/review/ ?

@TrueBrain TrueBrain force-pushed the pull_request_review branch from 282eab6 to a8cc0e3 Oct 6, 2018
LordAro approved these changes Oct 6, 2018
@TrueBrain TrueBrain merged commit 57dff11 into OpenTTD:master Oct 6, 2018
1 check passed
@TrueBrain TrueBrain deleted the pull_request_review branch Nov 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants