Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: check for URLs including trailing slash #13

Merged
merged 1 commit into from Jan 1, 2020

Conversation

@TrueBrain
Copy link
Member

TrueBrain commented Jan 1, 2020

Although this is not really relevant in our case, LGTM rightfully
indicates that these 'startswith' can still have URLs like
'https://api.github.com.fake.domain', and validate. We of course
not as much use the validation to check if it really comes from
github.com, merely to ensure that the next statement is valid.
Nevertheless, it is a sane change to make.

Although this is not really relevant in our case, LGTM rightfully
indicates that these 'startswith' can still have URLs like
'https://api.github.com.fake.domain', and validate. We of course
not as much use the validation to check if it really comes from
github.com, merely to ensure that the next statement is valid.
Nevertheless, it is a sane change to make.
@LordAro
LordAro approved these changes Jan 1, 2020
@TrueBrain TrueBrain merged commit 25fbc55 into OpenTTD:master Jan 1, 2020
2 checks passed
2 checks passed
Flake8
Details
Docker
Details
@TrueBrain TrueBrain deleted the TrueBrain:url_check_fix branch Jan 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.