Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: Use a white cursor for better visibility #46

Closed
wants to merge 1 commit into from

Conversation

Andrew350
Copy link
Contributor

@Andrew350 Andrew350 commented Dec 27, 2020

Orange is a terrible color for the cursor. I often lose track of it against the background, especially when it flickers while moving, so I made it white to increase visibility.

@andythenorth
Copy link
Contributor

@andythenorth andythenorth commented Dec 27, 2020

_Massive +1, I was using the WASM previews of OpenTTD. I never normally use OpenGFX. The OGFX cursor is horribly hard to see.

I don't think this is a valid case of "we just like what we are familiar with" either 😸_

EDIT: actually I take my nose out of this. I don't use OpenGFX except in the preview case.

Providing opinions on things that really don't affect me....isn't helpful if we want a healthy project.

@frosch123
Copy link
Member

@frosch123 frosch123 commented Dec 27, 2020

The cursor is used in all climated.
Try a white cursor in arctic climate above snowline.

Orange was picked, because it is best visible in most situations.

@frosch123 frosch123 closed this Dec 27, 2020
@frosch123
Copy link
Member

@frosch123 frosch123 commented Dec 27, 2020

Sorry, this is a PR. I thought it was an issue.
I'll leave it for discussion then.

@frosch123 frosch123 reopened this Dec 27, 2020
@andythenorth
Copy link
Contributor

@andythenorth andythenorth commented Dec 27, 2020

_Many successful cursors use high contrast almost-monochrome colours
e.g. black border on white cursor, or white border on black cursor

Original baseset cursor has no snowline visibility problem because

  1. it's fricking huge and chunky
  2. it's mostly grey, and uses substantial dark shadow under lower side of sprite_

TBH I should just stay out of this.

Providing opinions on things that really don't affect me....isn't helpful if we want a healthy project.

I've edited my previous comment to same effect. #46 (comment)

@Andrew350
Copy link
Contributor Author

@Andrew350 Andrew350 commented Dec 27, 2020

Try a white cursor in arctic climate above snowline.

I did, and made a little comparison. Top is current, middle is what's in the PR now, bottom is a test with some extra black for contrast:

cursor_arctic

My opinions:

  • Orange is definitely visible over snow, but not great everywhere else.

  • White only seems slightly less visible over snow (in-game at least), but is much more visible everywhere else.

  • White with a bit more black outline solves both issues, with the slight negative of making the cursor a bit more chonky (and perhaps a bit more work to fit into existing sprites)

Whether others agree or not is obviously important for the PR, but I will definitely be using this for my personal setup. Would love to see other input though 🙂

@TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented Dec 27, 2020

So used to the iconic orange, I would hate to lose that honestly :(

Wouldn't it be a good idea to make a tiny GRF like "white-mouse.grf" that does this? That allows others to use it too, without people who are very much used to the orange losing that? :D

@Andrew350
Copy link
Contributor Author

@Andrew350 Andrew350 commented Dec 27, 2020

That is definitely an option, if the consensus is against the change 🙂

@LordAro
Copy link
Member

@LordAro LordAro commented Mar 22, 2021

Executive decision: Reject this change. Less visible on snow (even with the bold outline, which is an improvement), and less reason to do so now that the flickering mouse issues have been fixed

Thanks for giving it a go!

@LordAro LordAro closed this Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants