Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: Improved infra06.png Monorail and Maglev roof sprites #63

Closed
wants to merge 0 commits into from

Conversation

supermop
Copy link

@supermop supermop commented Mar 24, 2021

This is my first PR and I am not really sure if I did this correctly, but this adds the infra06.png that has my changed roof sprites as discussed in #44

I am also working on some tweaks to the Rail roof, but that seemed less relevant to the issue and might be more controversial, so I did not add it here.

Thanks!

Closes #44

@supermop supermop changed the title Revised infra06.png with embellished Monorail and Maglev roof sprites Change: Improved infra06.png Monorail and Maglev roof sprites Mar 25, 2021
@supermop
Copy link
Author

@supermop supermop commented Mar 25, 2021

Before:
Before Infra06

After:
After Infra06

@Andrew350
Copy link
Contributor

@Andrew350 Andrew350 commented Mar 26, 2021

2 things:

  • I notice the transparency sprites (the yellow bits) no longer match up with the added superstructure. I don't know if that has any noticeable effect in-game (I haven't compiled to check), but may be worth looking at.

  • Given the complete fustercluck that is the OpenGFX repo, it may be worth splitting these new graphics into their own .png file. This would help distinguish them as new, actually used graphics, rather than the old/unused/duplicate/triplicate/etc graphics that otherwise litter the spritesheets. Just a suggestion though, they look great either way 🙂

@supermop
Copy link
Author

@supermop supermop commented Mar 27, 2021

2 things:

  • I notice the transparency sprites (the yellow bits) no longer match up with the added superstructure. I don't know if that has any noticeable effect in-game (I haven't compiled to check), but may be worth looking at.
  • Given the complete fustercluck that is the OpenGFX repo, it may be worth splitting these new graphics into their own .png file. This would help distinguish them as new, actually used graphics, rather than the old/unused/duplicate/triplicate/etc graphics that otherwise litter the spritesheets. Just a suggestion though, they look great either way 🙂

Don't line up with the CC frame, or with the silver part? I didn't change those sprites at all, so presumably they'd be the same as last year, but not sure. I don't have access to photoshop for a few days, so I'm not able to modify the PNG at the moment.

I am neutral on providing the sprites as a standalone png vs revising the big infra06 ... either way is fine with me, I just assumed replacing the big sheet would be easier as no code would need to change.

@supermop
Copy link
Author

@supermop supermop commented Mar 31, 2021

Just following up on this - is the current method of replacing infra06 unacceptable, or simply not preferred?

@LordAro
Copy link
Member

@LordAro LordAro commented Mar 31, 2021

Oops, sorry, looks like I broke it when trying to fix the commit messages. Can you remake the PR? (Use a branch other than 'master', it's bad practice and causes weirdnesses like this)

I don't think anything you did was unacceptable, but I'm no NewGRF developer either :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants