Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: [Actions] Make NML warnings more visible in pull requests #72

Merged
merged 5 commits into from Sep 25, 2021

Conversation

@glx22
Copy link
Contributor

@glx22 glx22 commented Sep 4, 2021

It's done by implementing a problem matcher for nmlc and addition of annotation check.
Also simplified commit-checker using the existing actions.

This PR won't pass annotation check, but it's expected (master branch is not warning free).

Copy link
Member

@TrueBrain TrueBrain left a comment

Rebase should fix the failing build now I guess!

Loading

@glx22
Copy link
Contributor Author

@glx22 glx22 commented Sep 16, 2021

Gimp annoyingly adds iCCP chunk in generated PNG, so I had to do an extra cleanup step after the generation to reduce the number of modified files.

And I don't understand why some PNGs were outdated as commit history says they should not.

Loading

@glx22 glx22 merged commit feea5b5 into OpenTTD:master Sep 25, 2021
3 checks passed
Loading
@glx22 glx22 deleted the problem_matcher branch Sep 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants