Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No tests (make check) is possible #22

Open
ConiKost opened this issue Jun 29, 2021 · 3 comments
Open

No tests (make check) is possible #22

ConiKost opened this issue Jun 29, 2021 · 3 comments

Comments

@ConiKost
Copy link

@ConiKost ConiKost commented Jun 29, 2021

Hi!
It seems, that 'make check' cannot be executed, as files? seems to be missing.

Basically, make check will always fail:
/usr/bin/grfid -m openmsx.grf > openmsx.md5
Unable to get requested information: Unable to open file

The problem is, the .grf is never created. If I try to run manually make grf, it will also fail, because it complains of missing openmsx.pnml

[CPP] openmsx.nml
cc -D REPO_REVISION=0 -D NEWGRF_VERSION=0  -C -E -nostdinc -x c-header -o openmsx.nml openmsx.pnml
cc1: fatal error: openmsx.pnml: No such file or directory
compilation terminated.

I am not sure, is it missing or does it has to be created somehow? I can't find anything realated about creation in the Makefile.

@glx22
Copy link
Contributor

@glx22 glx22 commented Jun 29, 2021

OpenMSX is not a newgrf, so none is created. But it uses the same Makefile as other projects.

Loading

@ConiKost
Copy link
Author

@ConiKost ConiKost commented Jun 29, 2021

So basically make check is here a no-op, as it won't work anyway?

Loading

@matthijskooijman
Copy link

@matthijskooijman matthijskooijman commented Nov 23, 2021

I also ran into this issue, see #30 for a list of this and some other build system issues. I'm not sure if make check was ever useful, since I suspect it's not used for multiplayer compatibility like grfs/OpenGFX?

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants